Provide object-level packages[].platforms[].toolsDependencies[] package index data to rules
#199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The package indexes for used for projectdata test data had the same packages[].platforms[].toolsDependencies data for every platform. Although there was nothing specifically wrong with this, it seems like diversity in the test data makes the tests more meaningful by differentiating the expected tools dependencies data for each platform.
…ge index data to rules Data checking rules for package indexes need to iterate over its object-level components. To facilitate this, slices of such objects accompanied by the necessary metadata are generated as package index project data. This was already done for packages, platforms, boards, and tools, but not for tools dependencies.
per1234
added
type: enhancement
Codecov Report
@@ Coverage Diff @@
## main #199 +/- ##
==========================================
+ Coverage 85.15% 85.16% +0.01%
==========================================
Files 43 43
Lines 3388 3391 +3
==========================================
+ Hits 2885 2888 +3
Misses 392 392
Partials 111 111
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
silvanocerza
approved these changes
Jun 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Data checking rules for package indexes need to iterate over its object-level components. To facilitate this, slices of
such objects accompanied by the necessary metadata are generated as package index project data.
This was already done for packages, platforms, boards, and tools, but not for tools dependencies.