Skip to content

Use a template to define package index component ID format #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2021
Merged

Use a template to define package index component ID format #198

merged 1 commit into from
Jun 23, 2021

Conversation

per1234
Copy link
Contributor

@per1234 per1234 commented Jun 23, 2021

The previous inflexible approach to defining the format of the identifiers used for package index components in rule
messages will not allow for identifying platform tool dependencies. A template approach will support any ID format.

The previous inflexible approach to defining the format of the identifiers used for package index components in rule
messages will not allow for identifying platform tool dependencies. A template approach will support any ID format.
@per1234 per1234 added type: bug topic: code Related to content of the project itself labels Jun 23, 2021
@per1234 per1234 requested review from silvanocerza and umbynos June 23, 2021 06:09
@codecov-commenter
Copy link

Codecov Report

Merging #198 (85e39fe) into main (288fe38) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #198      +/-   ##
==========================================
- Coverage   85.17%   85.15%   -0.02%     
==========================================
  Files          43       43              
  Lines        3392     3388       -4     
==========================================
- Hits         2889     2885       -4     
  Misses        392      392              
  Partials      111      111              
Flag Coverage Δ
unit 85.15% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/project/projectdata/packageindex.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 288fe38...85e39fe. Read the comment docs.

@per1234 per1234 merged commit 9cd738f into arduino:main Jun 23, 2021
@per1234 per1234 deleted the id-template branch June 23, 2021 06:55
@rsora rsora added the type: imperfection Perceived defect in any part of project label Sep 22, 2021
@per1234 per1234 self-assigned this Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants