From 630c5c3a396ec5013c0b0e9dcdfb88a9dcdb9cf7 Mon Sep 17 00:00:00 2001 From: per1234 Date: Sat, 3 Apr 2021 07:00:43 -0700 Subject: [PATCH] Use major version ref of action in workflow At the time the workflow was written the authors of the rtCamp/action-slack-notify GitHub Action did not provide a major version ref. This meant that it was necessary to pin the action to a specific version. Since then, a few new patch releases have been made, meaning an outdated version of the action was in use as a consequence of the pinning. The action now offers a `v2` major ref. Use of this ref will cause the workflow to benefit from ongoing development to the action up until such time as a new major release is made, at which time we would need to evaluate whether any changes to the workflow are required by the breaking change that triggered the major release before updating the major ref (e.g., `v3`). --- .github/workflows/check-certificates.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/check-certificates.yml b/.github/workflows/check-certificates.yml index c3628154..3db1bab1 100644 --- a/.github/workflows/check-certificates.yml +++ b/.github/workflows/check-certificates.yml @@ -57,7 +57,7 @@ jobs: # See: https://github.com/rtCamp/action-slack-notify - name: Slack notification of certificate verification failure if: failure() - uses: rtCamp/action-slack-notify@v2.1.0 + uses: rtCamp/action-slack-notify@v2 env: SLACK_WEBHOOK: ${{ secrets.TEAM_TOOLING_CHANNEL_SLACK_WEBHOOK }} SLACK_MESSAGE: | @@ -111,7 +111,7 @@ jobs: - name: Slack notification of pending certificate expiration # Don't send spurious expiration notification if verification fails if: failure() && steps.check-expiration.outcome == 'failure' - uses: rtCamp/action-slack-notify@v2.1.0 + uses: rtCamp/action-slack-notify@v2 env: SLACK_WEBHOOK: ${{ secrets.TEAM_TOOLING_CHANNEL_SLACK_WEBHOOK }} SLACK_MESSAGE: |