From 3e650750a4d1278b147f5daf5af125951831d317 Mon Sep 17 00:00:00 2001 From: per1234 Date: Mon, 8 Mar 2021 23:41:05 -0800 Subject: [PATCH] Disable LM-specific checks when in --library-manager=false mode The documentation of the `--library-manager` flag promises that, when set to `false`, Library Manager-specific rules will not run. Despite this, some such rules were configured to be warnings when in --library-manager=false mode. --- .../rule/ruleconfiguration/ruleconfiguration.go | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/internal/rule/ruleconfiguration/ruleconfiguration.go b/internal/rule/ruleconfiguration/ruleconfiguration.go index 0cf35f2e..f26593a5 100644 --- a/internal/rule/ruleconfiguration/ruleconfiguration.go +++ b/internal/rule/ruleconfiguration/ruleconfiguration.go @@ -162,11 +162,11 @@ var configurations = []Type{ Brief: ".exe file", Description: "", MessageTemplate: ".exe file(s) found: {{.}}. Presence of these files blocks addition to the Library Manager index.", - DisableModes: nil, - EnableModes: []rulemode.Type{rulemode.Default}, + DisableModes: []rulemode.Type{rulemode.Default}, + EnableModes: []rulemode.Type{rulemode.LibraryManagerSubmission, rulemode.LibraryManagerIndexed}, InfoModes: nil, - WarningModes: []rulemode.Type{rulemode.Default}, - ErrorModes: []rulemode.Type{rulemode.LibraryManagerSubmission, rulemode.LibraryManagerIndexed, rulemode.Strict}, + WarningModes: nil, + ErrorModes: []rulemode.Type{rulemode.Default}, RuleFunction: rulefunction.LibraryHasExe, }, { @@ -514,11 +514,11 @@ var configurations = []Type{ Brief: "duplicate name", Description: "This requirement only applies to the library.properties name value. There is no requirement to change the repository or header file names.", MessageTemplate: "Library name {{.}} is in use by a library in the Library Manager index. Each library must have a unique name value. If your library is already in the index, use the \"--library-manager update\" flag.", - DisableModes: []rulemode.Type{rulemode.LibraryManagerIndexed}, - EnableModes: []rulemode.Type{rulemode.Default}, + DisableModes: []rulemode.Type{rulemode.Default}, + EnableModes: []rulemode.Type{rulemode.LibraryManagerSubmission}, InfoModes: nil, - WarningModes: []rulemode.Type{rulemode.Default}, - ErrorModes: []rulemode.Type{rulemode.LibraryManagerSubmission}, + WarningModes: nil, + ErrorModes: []rulemode.Type{rulemode.Default}, RuleFunction: rulefunction.LibraryPropertiesNameFieldDuplicate, }, {