From bd76231746f2b15ce1de6e4ab9a3369c8798d470 Mon Sep 17 00:00:00 2001 From: per1234 Date: Mon, 11 Jan 2021 20:55:40 -0800 Subject: [PATCH 1/2] Use appropriate log level for programmers.txt/platform.txt load failure These platform configuration files are optional, so the previous error level was inappropriate. --- internal/project/projectdata/platform.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/internal/project/projectdata/platform.go b/internal/project/projectdata/platform.go index 0aa92abe..a6b4f339 100644 --- a/internal/project/projectdata/platform.go +++ b/internal/project/projectdata/platform.go @@ -44,7 +44,7 @@ func InitializeForPlatform(project project.Type) { programmersTxt, programmersTxtLoadError = programmerstxt.Properties(ProjectPath()) if programmersTxtLoadError != nil { - logrus.Errorf("Error loading programmers.txt from %s: %s", project.Path, programmersTxtLoadError) + logrus.Tracef("Error loading programmers.txt from %s: %s", project.Path, programmersTxtLoadError) programmersTxtSchemaValidationResult = nil } else { programmersTxtSchemaValidationResult = programmerstxt.Validate(programmersTxt) @@ -56,7 +56,7 @@ func InitializeForPlatform(project project.Type) { platformTxt, platformTxtLoadError = platformtxt.Properties(ProjectPath()) if platformTxtLoadError != nil { - logrus.Errorf("Error loading platform.txt from %s: %s", project.Path, platformTxtLoadError) + logrus.Tracef("Error loading platform.txt from %s: %s", project.Path, platformTxtLoadError) platformTxtSchemaValidationResult = nil platformTxtToolNames = nil } else { From 94a19c10986d49be13bbedcaf5f7174f3eb4bfea Mon Sep 17 00:00:00 2001 From: per1234 Date: Mon, 11 Jan 2021 20:57:33 -0800 Subject: [PATCH 2/2] Set logging level to fatal when running platform rule function tests The tests use a platform that is missing a boards.txt file. With the logger's default "info" level, this results in a useless log line for every one of those tests. --- internal/rule/rulefunction/platform_test.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/internal/rule/rulefunction/platform_test.go b/internal/rule/rulefunction/platform_test.go index f326487b..db53a918 100644 --- a/internal/rule/rulefunction/platform_test.go +++ b/internal/rule/rulefunction/platform_test.go @@ -25,12 +25,14 @@ import ( "github.com/arduino/arduino-lint/internal/project/projecttype" "github.com/arduino/arduino-lint/internal/rule/ruleresult" "github.com/arduino/go-paths-helper" + "github.com/sirupsen/logrus" "github.com/stretchr/testify/assert" ) var platformTestDataPath *paths.Path func init() { + logrus.SetLevel(logrus.FatalLevel) workingDirectory, err := paths.Getwd() if err != nil { panic(err)