Merge pull request #510 from per1234/allow_sketch_leading_underscore

Allow leading underscore in sketch filenames

Author: per1234

Diff for: internal/rule/rulefunction/rulefunction.go

@@ -105,7 +105,7 @@ func brokenOutputList(list []string) string {
 
 // validProjectPathBaseName checks whether the provided library folder or sketch filename contains prohibited characters.
 func validProjectPathBaseName(name string) bool {
-	baseNameRegexp := regexp.MustCompile("^[a-zA-Z0-9][a-zA-Z0-9_.-]*$")
+	baseNameRegexp := regexp.MustCompile("^[a-zA-Z0-9_][a-zA-Z0-9_.-]*$")
 	return baseNameRegexp.MatchString(name)
 }
 

Diff for: internal/rule/rulefunction/sketch_test.go

@@ -75,7 +75,7 @@ func TestSketchNameMismatch(t *testing.T) {
 func TestProhibitedCharactersInSketchFileName(t *testing.T) {
 	testTables := []sketchRuleFunctionTestTable{
 		{"Has prohibited characters", "ProhibitedCharactersInFileName", ruleresult.Fail, "^Prohibited CharactersInFileName.h$"},
-		{"No prohibited characters", "Valid", ruleresult.Pass, ""},
+		{"No prohibited characters", "AllowedCharactersInFilenames", ruleresult.Pass, ""},
 	}
 
 	checkSketchRuleFunction(ProhibitedCharactersInSketchFileName, testTables, t)

Diff for: internal/rule/rulefunction/testdata/sketches/AllowedCharactersInFilenames/1LeadingNumber.ino

@@ -0,0 +1,2 @@
+void setup() {}
+void loop() {}