Skip to content

Commit 6529e20

Browse files
authored
Merge pull request #803 from per1234/fix-release-workflows
Fix collision between macOS workflow artifacts in release workflows
2 parents 762375c + e2ee58f commit 6529e20

File tree

2 files changed

+16
-10
lines changed

2 files changed

+16
-10
lines changed

Diff for: .github/workflows/publish-go-nightly-task.yml

+8-5
Original file line numberDiff line numberDiff line change
@@ -81,9 +81,11 @@ jobs:
8181
strategy:
8282
matrix:
8383
build:
84-
- folder-suffix: darwin_amd64
84+
- artifact-suffix: macOS_64bit
85+
folder-suffix: darwin_amd64
8586
package-suffix: "macOS_64bit.tar.gz"
86-
- folder-suffix: darwin_arm64
87+
- artifact-suffix: macOS_ARM64
88+
folder-suffix: darwin_arm64
8789
package-suffix: "macOS_ARM64.tar.gz"
8890

8991
steps:
@@ -172,11 +174,12 @@ jobs:
172174
-C ../../ LICENSE.txt
173175
echo "PACKAGE_FILENAME=$PACKAGE_FILENAME" >> $GITHUB_ENV
174176
175-
- name: Upload artifact
177+
- name: Replace artifact with notarized build
176178
uses: actions/upload-artifact@v4
177179
with:
178180
if-no-files-found: error
179-
name: ${{ env.ARTIFACT_PREFIX }}notarized-${{ matrix.build.folder-suffix }}
181+
name: ${{ env.ARTIFACT_PREFIX }}${{ matrix.build.artifact-suffix }}
182+
overwrite: true
180183
path: ${{ env.DIST_DIR }}/${{ env.PACKAGE_FILENAME }}
181184

182185
publish-nightly:
@@ -193,7 +196,7 @@ jobs:
193196
path: ${{ env.DIST_DIR }}
194197

195198
- name: Create checksum file
196-
working-directory: ${{ env.DIST_DIR}}
199+
working-directory: ${{ env.DIST_DIR }}
197200
run: |
198201
TAG="nightly-$(date -u +"%Y%m%d")"
199202
sha256sum ${{ env.PROJECT_NAME }}_${TAG}* > ${TAG}-checksums.txt

Diff for: .github/workflows/release-go-task.yml

+8-5
Original file line numberDiff line numberDiff line change
@@ -88,9 +88,11 @@ jobs:
8888
strategy:
8989
matrix:
9090
build:
91-
- folder-suffix: darwin_amd64
91+
- artifact-suffix: macOS_64bit
92+
folder-suffix: darwin_amd64
9293
package-suffix: "macOS_64bit.tar.gz"
93-
- folder-suffix: darwin_arm64
94+
- artifact-suffix: macOS_ARM64
95+
folder-suffix: darwin_arm64
9496
package-suffix: "macOS_ARM64.tar.gz"
9597

9698
steps:
@@ -178,11 +180,12 @@ jobs:
178180
-C "${{ env.BUILD_FOLDER }}/" "${{ env.PROJECT_NAME }}" \
179181
-C ../../ LICENSE.txt
180182
181-
- name: Upload artifact
183+
- name: Replace artifact with notarized build
182184
uses: actions/upload-artifact@v4
183185
with:
184186
if-no-files-found: error
185-
name: ${{ env.ARTIFACT_PREFIX }}notarized-${{ matrix.build.folder-suffix }}
187+
name: ${{ env.ARTIFACT_PREFIX }}${{ matrix.build.artifact-suffix }}
188+
overwrite: true
186189
path: ${{ env.DIST_DIR }}/${{ env.PACKAGE_FILENAME }}
187190

188191
create-release:
@@ -200,7 +203,7 @@ jobs:
200203
path: ${{ env.DIST_DIR }}
201204

202205
- name: Create checksum file
203-
working-directory: ${{ env.DIST_DIR}}
206+
working-directory: ${{ env.DIST_DIR }}
204207
run: |
205208
TAG="${GITHUB_REF/refs\/tags\//}"
206209
sha256sum ${{ env.PROJECT_NAME }}_${TAG}* > ${TAG}-checksums.txt

0 commit comments

Comments
 (0)