Skip to content

Commit 4e6c832

Browse files
authored
Merge pull request #265 from per1234/schema-validation-error-handling
Panic on unexpected schema validation error
2 parents 3b6da1c + 31c699b commit 4e6c832

File tree

1 file changed

+10
-2
lines changed

1 file changed

+10
-2
lines changed

Diff for: internal/rule/schema/schema.go

+10-2
Original file line numberDiff line numberDiff line change
@@ -81,11 +81,19 @@ func Compile(schemaFilename string, referencedSchemaFilenames []string, dataLoad
8181
// jsonschema.ValidationError object otherwise.
8282
func Validate(instanceInterface map[string]interface{}, schemaObject Schema) ValidationResult {
8383
validationError := schemaObject.Compiled.ValidateInterface(instanceInterface)
84-
result, _ := validationError.(*jsonschema.ValidationError)
8584
validationResult := ValidationResult{
86-
Result: result,
85+
Result: nil,
8786
dataLoader: schemaObject.dataLoader,
8887
}
88+
89+
if validationError != nil {
90+
result, ok := validationError.(*jsonschema.ValidationError)
91+
if !ok {
92+
panic(validationError)
93+
}
94+
validationResult.Result = result
95+
}
96+
8997
if validationResult.Result == nil {
9098
logrus.Debug("Schema validation of instance document passed")
9199
} else {

0 commit comments

Comments
 (0)