Provide natively loaded data as package index project data

Arduino CLI's package index loading function can can be useful in its current capacity as a general check on the validity
of the package index as far as Arduino CLI is concerned, used for that purpose by a single dedicated rule.

However, it can not be used as a data source for other rules because Arduino CLI should attempt to be resilient to bad
data when possible, while Arduino Lint needs to detect the very bad data that Arduino CLI might correct.

So the data from the native loading code must be used in all rules, while the value from Arduino CLI's load is solely in
whether or not it returned an error.

Author: per1234

Diff for: internal/project/projectdata/packageindex.go

@@ -16,26 +16,35 @@
 package projectdata
 
 import (
-	"github.com/arduino/arduino-cli/arduino/cores/packageindex"
+	clipackageindex "github.com/arduino/arduino-cli/arduino/cores/packageindex"
+	"github.com/arduino/arduino-lint/internal/project/packageindex"
 )
 
 // InitializeForPackageIndex gathers the package index rule data for the specified project.
 func InitializeForPackageIndex() {
+	packageIndex, packageIndexLoadError = packageindex.Properties(ProjectPath())
 	if ProjectPath() != nil {
-		packageIndex, packageIndexLoadError = packageindex.LoadIndex(ProjectPath())
+		_, packageIndexCLILoadError = clipackageindex.LoadIndex(ProjectPath())
 	}
 }
 
-var packageIndex *packageindex.Index
+var packageIndex map[string]interface{}
 
-// PackageIndex returns the packageindex.Index object generated by Arduino CLI.
-func PackageIndex() *packageindex.Index {
+// PackageIndex returns the package index data.
+func PackageIndex() map[string]interface{} {
 	return packageIndex
 }
 
 var packageIndexLoadError error
 
-// PackageIndexLoadError returns the error return of packageindex.LoadIndex().
+// PackageIndexLoadError returns the error from loading the package index.
 func PackageIndexLoadError() error {
 	return packageIndexLoadError
 }
+
+var packageIndexCLILoadError error
+
+// PackageIndexCLILoadError returns the error return of Arduino CLI's packageindex.LoadIndex().
+func PackageIndexCLILoadError() error {
+	return packageIndexCLILoadError
+}

Diff for: internal/project/projectdata/packageindex_test.go

@@ -36,14 +36,15 @@ func init() {
 
 func TestInitializeForPackageIndex(t *testing.T) {
 	testTables := []struct {
-		testName                       string
-		path                           *paths.Path
-		packageIndexAssertion          assert.ValueAssertionFunc
-		packageIndexLoadErrorAssertion assert.ValueAssertionFunc
+		testName                          string
+		path                              *paths.Path
+		packageIndexAssertion             assert.ValueAssertionFunc
+		packageIndexLoadErrorAssertion    assert.ValueAssertionFunc
+		packageIndexCLILoadErrorAssertion assert.ValueAssertionFunc
 	}{
-		{"Valid", packageIndexTestDataPath.Join("valid-package-index", "package_foo_index.json"), assert.NotNil, assert.Nil},
-		{"Invalid package index", packageIndexTestDataPath.Join("invalid-package-index", "package_foo_index.json"), assert.Nil, assert.NotNil},
-		{"Invalid JSON", packageIndexTestDataPath.Join("invalid-JSON", "package_foo_index.json"), assert.Nil, assert.NotNil},
+		{"Valid", packageIndexTestDataPath.Join("valid-package-index", "package_foo_index.json"), assert.NotNil, assert.Nil, assert.Nil},
+		{"Invalid package index", packageIndexTestDataPath.Join("invalid-package-index", "package_foo_index.json"), assert.Nil, assert.NotNil, assert.NotNil},
+		{"Invalid JSON", packageIndexTestDataPath.Join("invalid-JSON", "package_foo_index.json"), assert.Nil, assert.NotNil, assert.NotNil},
 	}
 
 	for _, testTable := range testTables {
@@ -56,6 +57,7 @@ func TestInitializeForPackageIndex(t *testing.T) {
 		Initialize(testProject)
 
 		testTable.packageIndexLoadErrorAssertion(t, PackageIndexLoadError(), testTable.testName)
+		testTable.packageIndexCLILoadErrorAssertion(t, PackageIndexCLILoadError(), testTable.testName)
 		if PackageIndexLoadError() == nil {
 			testTable.packageIndexAssertion(t, PackageIndex(), testTable.testName)
 		}

Diff for: internal/rule/rulefunction/packageindex.go

@@ -77,8 +77,8 @@ func PackageIndexFormat() (result ruleresult.Type, output string) {
 		return ruleresult.NotRun, "Package index not found"
 	}
 
-	if projectdata.PackageIndexLoadError() != nil {
-		return ruleresult.Fail, projectdata.PackageIndexLoadError().Error()
+	if projectdata.PackageIndexCLILoadError() != nil {
+		return ruleresult.Fail, projectdata.PackageIndexCLILoadError().Error()
 	}
 
 	return ruleresult.Pass, ""