Skip to content

Commit 104501e

Browse files
committed
Remove unused job outputs from release workflows
In a previous revision of the release workflows, the updated checksums were determined by the macOS notarization job and then passed to the subsequent job via job outputs. That approach was changed during a later refactoring, but the code that declares the job outputs was not removed at that time. The checksum job output declaration code is now unused (and unusable since the checksum determination and output definitions were removed) so it only makes the workflows more difficult to understand and maintain. For this reason, the vestigial code is hereby removed from the workflows.
1 parent c79c71c commit 104501e

File tree

2 files changed

+0
-10
lines changed

2 files changed

+0
-10
lines changed

.github/workflows/publish-go-nightly-task.yml

-6
Original file line numberDiff line numberDiff line change
@@ -72,11 +72,6 @@ jobs:
7272
name: Notarize ${{ matrix.build.folder-suffix }}
7373
runs-on: macos-latest
7474
needs: create-nightly-artifacts
75-
76-
outputs:
77-
checksum-darwin_amd64: ${{ steps.re-package.outputs.checksum-darwin_amd64 }}
78-
checksum-darwin_arm64: ${{ steps.re-package.outputs.checksum-darwin_arm64 }}
79-
8075
permissions:
8176
contents: read
8277

@@ -163,7 +158,6 @@ jobs:
163158
gon "${{ env.GON_CONFIG_PATH }}"
164159
165160
- name: Re-package binary
166-
id: re-package
167161
working-directory: ${{ env.DIST_DIR }}
168162
# Repackage the signed binary replaced in place by Gon (ignoring the output zip file)
169163
run: |

.github/workflows/release-go-task.yml

-4
Original file line numberDiff line numberDiff line change
@@ -79,9 +79,6 @@ jobs:
7979
name: Notarize ${{ matrix.build.folder-suffix }}
8080
runs-on: macos-latest
8181
needs: create-release-artifacts
82-
outputs:
83-
checksum-darwin_amd64: ${{ steps.re-package.outputs.checksum-darwin_amd64 }}
84-
checksum-darwin_arm64: ${{ steps.re-package.outputs.checksum-darwin_arm64 }}
8582
permissions:
8683
contents: read
8784

@@ -170,7 +167,6 @@ jobs:
170167
gon "${{ env.GON_CONFIG_PATH }}"
171168
172169
- name: Re-package binary
173-
id: re-package
174170
working-directory: ${{ env.DIST_DIR }}
175171
# Repackage the signed binary replaced in place by Gon (ignoring the output zip file)
176172
run: |

0 commit comments

Comments
 (0)