Skip to content

Commit 0c6a65d

Browse files
committed
Implement rule message improvements requested in PR review
1 parent 2ff2ca5 commit 0c6a65d

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

internal/rule/ruleconfiguration/ruleconfiguration.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -256,7 +256,7 @@ var configurations = []Type{
256256
Subcategory: "general",
257257
ID: "LP001",
258258
Brief: "missing library.properties",
259-
Description: `Although not required for 1.0 format libraries (AKA "legacy") not in Library Manager, metadata is useful, so it is recommended.`,
259+
Description: `Although not required for 1.0 format libraries (AKA "legacy") not in Library Manager, metadata is useful, hence recommended.`,
260260
MessageTemplate: "Library has no library.properties metadata file. This file provides useful information and is required for admission to the Library Manager index. See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-metadata",
261261
DisableModes: nil,
262262
EnableModes: []rulemode.Type{rulemode.Default},
@@ -401,7 +401,7 @@ var configurations = []Type{
401401
ID: "LP010",
402402
Brief: "name > recommended length",
403403
Description: "",
404-
MessageTemplate: "library.properties name value {{.}} is longer than recommended length of 16 characters.",
404+
MessageTemplate: "library.properties name value {{.}} is longer than the recommended length of 16 characters.",
405405
DisableModes: nil,
406406
EnableModes: []rulemode.Type{rulemode.Default},
407407
InfoModes: nil,
@@ -513,7 +513,7 @@ var configurations = []Type{
513513
ID: "LP017",
514514
Brief: "duplicate name",
515515
Description: "This requirement only applies to the library.properties name value. There is no requirement to change the repository or header file names.",
516-
MessageTemplate: "Library name {{.}} is in use by a library in the Library Manager index. Each library must have a unique name value. If library is already in the index, use the \"--library-manager update\" flag.",
516+
MessageTemplate: "Library name {{.}} is in use by a library in the Library Manager index. Each library must have a unique name value. If your library is already in the index, use the \"--library-manager update\" flag.",
517517
DisableModes: []rulemode.Type{rulemode.LibraryManagerIndexed},
518518
EnableModes: []rulemode.Type{rulemode.Default},
519519
InfoModes: nil,

0 commit comments

Comments
 (0)