Skip to content

Update go-lsp to v0.1.1 #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 10, 2023
Merged

Update go-lsp to v0.1.1 #149

merged 1 commit into from
Jan 10, 2023

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Jan 10, 2023

Please check if the PR fulfills these requirements

What kind of change does this PR introduce?

What is the current behavior?
Paths containing # are not correctly translated into file:// URI (the path past the # is transformed into uri fragment and discarded)

What is the new behavior?
Paths containing # are correctly translated into file:// URI.

@cmaglie cmaglie requested a review from kittaakos January 10, 2023 09:22
@cmaglie cmaglie self-assigned this Jan 10, 2023
@kittaakos
Copy link
Contributor

Unfortunately, arduino/arduino-ide#1124 is not resolved. I still see errors in the LS logs. I continue the investigation:

{"jsonrpc":"2.0","method":"textDocument/didChange","params":{"textDocument":{"uri":"file:///private/var/folders/z1/xkw1yh5n7rz4n8djprp1mdn80000gn/T/arduino-language-server1842245322/sketch/alma#korte.ino.cpp","version":3},"contentChanges":[{"range":{"start":{"line":2,"character":15},"end":{"line":2,"character":15}},"text":"a"}]}}Content-Length: 225

{"jsonrpc":"2.0","id":"5","method":"textDocument/documentSymbol","params":{"textDocument":{"uri":"file:///private/var/folders/z1/xkw1yh5n7rz4n8djprp1mdn80000gn/T/arduino-language-server1842245322/sketch/alma#korte.ino.cpp"}}}
<<<
Content-Length: 103

{"error":{"code":-32602,"message":"trying to get AST for non-added document"},"id":"5","jsonrpc":"2.0"}
>>>
Content-Length: 225

{"jsonrpc":"2.0","method":"textDocument/publishDiagnostics","params":{"diagnostics":[],"uri":"file:///private/var/folders/z1/xkw1yh5n7rz4n8djprp1mdn80000gn/T/arduino-language-server1842245322/sketch/alma%23korte.ino.cpp","version":1}}Content-Length: 93

{"error":{"code":-32001,"message":"Line value is out of range (2)"},"id":"2","jsonrpc":"2.0"}
>>>
Content-Length: 225

@cmaglie
Copy link
Member Author

cmaglie commented Jan 10, 2023

Unfortunately, arduino/arduino-ide#1124 is not resolved. I still see errors in the LS logs. I continue the investigation:

I messed up with the lib version 🤦🏼!

Sorry... it should be fine now.

@cmaglie cmaglie changed the title Update go-lsp to v0.1.0 Update go-lsp to v0.1.1 Jan 10, 2023
@cmaglie cmaglie added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Jan 10, 2023
kittaakos
kittaakos approved these changes Jan 10, 2023
View reviewed changes
Copy link
Contributor

@kittaakos kittaakos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's working great. I am on b5b1e28, manually built the LS. and dropped it into IDE2:

It resolves arduino/arduino-ide#1124

verify_1124.mp4

@cmaglie cmaglie merged commit 4467636 into main Jan 10, 2023
@cmaglie cmaglie deleted the update_lsp branch January 10, 2023 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kittaakos kittaakos kittaakos approved these changes

Assignees

@cmaglie cmaglie

Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmaglie @kittaakos