Skip to content

Commit e9ee267

Browse files
committed
When logging command output add also the command line args
1 parent eea4010 commit e9ee267

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

Diff for: handler/builder.go

+4-4
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@ func generateCompileFlags(tempDir, inoPath, sourcePath, fqbn string) (string, er
140140
propertiesCmd := exec.Command(globalCliPath, cliArgs...)
141141
output, err := propertiesCmd.Output()
142142
if err != nil {
143-
err = logCommandErr(globalCliPath, output, err, errMsgFilter(tempDir))
143+
err = logCommandErr(propertiesCmd, output, err, errMsgFilter(tempDir))
144144
return "", err
145145
}
146146
buildProps, err := properties.LoadFromBytes(output)
@@ -171,7 +171,7 @@ func generateTargetFile(tempDir, inoPath, cppPath, fqbn string) (cppCode []byte,
171171
preprocessCmd := exec.Command(globalCliPath, cliArgs...)
172172
cppCode, err = preprocessCmd.Output()
173173
if err != nil {
174-
err = logCommandErr(globalCliPath, cppCode, err, errMsgFilter(tempDir))
174+
err = logCommandErr(preprocessCmd, cppCode, err, errMsgFilter(tempDir))
175175
return
176176
}
177177

@@ -331,9 +331,9 @@ func splitFlags(flags string) string {
331331
return string(result)
332332
}
333333

334-
func logCommandErr(command string, stdout []byte, err error, filter func(string) string) error {
334+
func logCommandErr(command *exec.Cmd, stdout []byte, err error, filter func(string) string) error {
335335
message := ""
336-
log.Println("Command error:", command, err)
336+
log.Println("Command error:", command.Args, err)
337337
if len(stdout) > 0 {
338338
stdoutStr := string(stdout)
339339
log.Println("------------------------------BEGIN STDOUT\n", stdoutStr, "------------------------------END STDOUT")

0 commit comments

Comments
 (0)