Skip to content

Commit 1a68dfb

Browse files
authored
Merge pull request #201 from per1234/fix-release-tasks
Fix container-related misconfigurations in release build tasks
2 parents 5444eb5 + a14dd93 commit 1a68dfb

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

Diff for: DistTasks.yml

+7-4
Original file line numberDiff line numberDiff line change
@@ -131,11 +131,12 @@ tasks:
131131
desc: Builds Linux ARMv6 binaries
132132
dir: "{{.DIST_DIR}}"
133133
cmds:
134+
# "git config safe.directory" is required until this is fixed https://github.com/elastic/golang-crossbuild/issues/232
134135
- |
135136
docker run -v `pwd`/..:/home/build -w /home/build \
136137
-e CGO_ENABLED=1 \
137138
{{.CONTAINER}}:{{.CONTAINER_TAG}} \
138-
--build-cmd "{{.BUILD_COMMAND}}" \
139+
--build-cmd "git config --global --add safe.directory /home/build && {{.BUILD_COMMAND}}" \
139140
-p "{{.BUILD_PLATFORM}}"
140141
141142
tar cz -C {{.PLATFORM_DIR}} {{.PROJECT_NAME}} -C ../.. LICENSE.txt -f {{.PACKAGE_NAME}}
@@ -172,7 +173,7 @@ tasks:
172173
#
173174
# Until there is a fix released we must use a recent gcc for Linux_ARMv6 build, so for this
174175
# build we select the debian10 based container.
175-
CONTAINER_TAG: "{{.GO_VERSION}}-armel-debian10"
176+
CONTAINER_TAG: "{{.GO_VERSION}}-armel-debian11"
176177
PACKAGE_PLATFORM: "Linux_ARMv6"
177178
PACKAGE_NAME: "{{.PROJECT_NAME}}_{{.VERSION}}_{{.PACKAGE_PLATFORM}}.tar.gz"
178179

@@ -201,11 +202,12 @@ tasks:
201202
desc: Builds Mac OS X 64 bit binaries
202203
dir: "{{.DIST_DIR}}"
203204
cmds:
205+
# "git config safe.directory" is required until this is fixed https://github.com/elastic/golang-crossbuild/issues/232
204206
- |
205207
docker run -v `pwd`/..:/home/build -w /home/build \
206208
-e CGO_ENABLED=1 \
207209
{{.CONTAINER}}:{{.CONTAINER_TAG}} \
208-
--build-cmd "{{.BUILD_COMMAND}}" \
210+
--build-cmd "git config --global --add safe.directory /home/build && {{.BUILD_COMMAND}}" \
209211
-p "{{.BUILD_PLATFORM}}"
210212
211213
tar cz -C {{.PLATFORM_DIR}} {{.PROJECT_NAME}} -C ../.. LICENSE.txt -f {{.PACKAGE_NAME}}
@@ -235,11 +237,12 @@ tasks:
235237
desc: Builds Mac OS X ARM64 binaries
236238
dir: "{{.DIST_DIR}}"
237239
cmds:
240+
# "git config safe.directory" is required until this is fixed https://github.com/elastic/golang-crossbuild/issues/232
238241
- |
239242
docker run -v `pwd`/..:/home/build -w /home/build \
240243
-e CGO_ENABLED=1 \
241244
{{.CONTAINER}}:{{.CONTAINER_TAG}} \
242-
--build-cmd "{{.BUILD_COMMAND}}" \
245+
--build-cmd "git config --global --add safe.directory /home/build && {{.BUILD_COMMAND}}" \
243246
-p "{{.BUILD_PLATFORM}}"
244247
245248
tar cz -C {{.PLATFORM_DIR}} {{.PROJECT_NAME}} -C ../.. LICENSE.txt -f {{.PACKAGE_NAME}}

0 commit comments

Comments
 (0)