Implement a no-op workspace/didChangeConfiguration (#114)

joewreschnig · cmaglie · commit 0384c34cea76 · 2022-07-05T16:22:50.000+02:00
diff --git a/ls/lsp_server_ide.go b/ls/lsp_server_ide.go
@@ -229,7 +229,14 @@ func (server *IDELSPServer) WorkspaceDidChangeWorkspaceFolders(logger jsonrpc.Fu
 }
 
 func (server *IDELSPServer) WorkspaceDidChangeConfiguration(logger jsonrpc.FunctionLogger, params *lsp.DidChangeConfigurationParams) {
-	panic("unimplemented")
+	// At least one LSP client, Eglot, sends this by default when
+	// first connecting, even if the otions are empty.
+	// https://github.com/joaotavora/eglot/blob/e835996e16610d0ded6d862214b3b452b8803ea8/eglot.el#L1080
+	//
+	// Since ALS doesn’t have any workspace configuration yet,
+	// ignore it.
+	return
+
 }
 
 func (server *IDELSPServer) WorkspaceDidChangeWatchedFiles(logger jsonrpc.FunctionLogger, params *lsp.DidChangeWatchedFilesParams) {

Original file line number	Diff line number	Diff line change
`@@ -229,7 +229,14 @@ func (server *IDELSPServer) WorkspaceDidChangeWorkspaceFolders(logger jsonrpc.Fu`
`229`	`229`	`}`
`230`	`230`
`231`	`231`	`func (server IDELSPServer) WorkspaceDidChangeConfiguration(logger jsonrpc.FunctionLogger, params lsp.DidChangeConfigurationParams) {`
`232`		`- panic("unimplemented")`
	`232`	`+ // At least one LSP client, Eglot, sends this by default when`
	`233`	`+ // first connecting, even if the otions are empty.`
	`234`	`+ // https://github.com/joaotavora/eglot/blob/e835996e16610d0ded6d862214b3b452b8803ea8/eglot.el#L1080`
	`235`	`+ //`
	`236`	`+ // Since ALS doesn’t have any workspace configuration yet,`
	`237`	`+ // ignore it.`
	`238`	`+ return`
	`239`	`+`
`233`	`240`	`}`
`234`	`241`
`235`	`242`	`func (server IDELSPServer) WorkspaceDidChangeWatchedFiles(logger jsonrpc.FunctionLogger, params lsp.DidChangeWatchedFilesParams) {`