Skip to content

Commit bdbc9f3

Browse files
author
Fabrizio Mirabito
authoredSep 16, 2019
Merge pull request #115 from arduino/Fixed-decoding-of-multi-value-properties
Fixed decoding of multi value properties
2 parents a878619 + b052949 commit bdbc9f3

File tree

1 file changed

+8
-5
lines changed

1 file changed

+8
-5
lines changed
 

‎src/index.js

+8-5
Original file line numberDiff line numberDiff line change
@@ -126,9 +126,10 @@ const connect = options => new Promise((resolve, reject) => {
126126

127127
let valueToSend = {};
128128
let propertyNameKeyPrevious = '';
129+
let propertyNameKey = '';
129130
propertyValue.forEach((p) => {
130131
// Support cbor labels
131-
let propertyNameKey = p.n !== undefined ? p.n : p['0'];
132+
propertyNameKey = p.n !== undefined ? p.n : p['0'];
132133
const propertyNameKeySplit = propertyNameKey.split(':');
133134

134135
const valueKey = p.v !== undefined ? 'v' : '2';
@@ -148,8 +149,10 @@ const connect = options => new Promise((resolve, reject) => {
148149
if (propertyNameKeyPrevious === '') {
149150
propertyNameKeyPrevious = propertyNameKeySplit[propertyNameId];
150151
}
151-
if (propertyNameKeyPrevious !== propertyNameKey && propertyCallback[msg.topic][propertyNameKeyPrevious]) {
152-
propertyCallback[msg.topic][propertyNameKeyPrevious](valueToSend);
152+
if (propertyNameKeyPrevious !== propertyNameKey) {
153+
if (propertyCallback[msg.topic][propertyNameKeyPrevious]) {
154+
propertyCallback[msg.topic][propertyNameKeyPrevious](valueToSend);
155+
}
153156
propertyNameKeyPrevious = propertyNameKey;
154157
valueToSend = {};
155158
}
@@ -160,8 +163,8 @@ const connect = options => new Promise((resolve, reject) => {
160163
valueToSend[attributeName] = value;
161164
}
162165
});
163-
if (valueToSend !== {} && propertyCallback[msg.topic][propertyNameKeyPrevious]) {
164-
propertyCallback[msg.topic][propertyNameKeyPrevious](valueToSend);
166+
if (valueToSend !== {} && propertyCallback[msg.topic][propertyNameKey]) {
167+
propertyCallback[msg.topic][propertyNameKey](valueToSend);
165168
}
166169
}
167170
};

0 commit comments

Comments
 (0)
Please sign in to comment.