Lint

Author: pirropirro

.eslintrc.js

@@ -5,7 +5,6 @@ module.exports = {
   ignorePatterns: ['node_modules/*', 'lib/*', 'es/*'],
   parser: '@typescript-eslint/parser',
   extends: [
-    'plugin:react/recommended',
     'plugin:@typescript-eslint/recommended',
     'prettier/@typescript-eslint',
     'plugin:prettier/recommended',
@@ -23,14 +22,7 @@ module.exports = {
     '@typescript-eslint/no-empty-interface': 'warn',
     '@typescript-eslint/no-empty-function': 'warn',
     '@typescript-eslint/no-namespace': 'warn',
-    'react/display-name': 'warn',
-    'react/prop-types': 'warn',
     'prefer-rest-params': 'warn',
     'no-else-return': 'error',
   },
-  settings: {
-    react: {
-      version: 'detect',
-    },
-  },
 };

.prettierrc

@@ -0,0 +1,5 @@
+{
+  "printWidth": 120,
+  "singleQuote": true,
+  "trailingComma": "es5"
+}

package-lock.json

@@ -30,13 +30,19 @@
     "@types/jest": "^26.0.0",
     "@types/jws": "^3.2.2",
     "@types/mqtt": "^2.5.0",
+    "@types/node": "^14.0.13",
     "@types/node-fetch": "^2.5.7",
     "@types/react": "^16.9.13",
     "@types/react-dom": "^16.9.4",
     "@types/sinon": "^7.5.1",
     "@types/whatwg-fetch": "0.0.33",
-    "eslint": "^7.2.0",
+    "@typescript-eslint/eslint-plugin": "^2.25.0",
+    "@typescript-eslint/parser": "^2.25.0",
+    "eslint": "^6.8.0",
+    "eslint-config-prettier": "^6.10.1",
+    "eslint-plugin-prettier": "^3.1.2",
     "jest": "^26.0.1",
+    "prettier": "^2.0.5",
     "rimraf": "^3.0.2",
     "rollup": "^2.3.3",
     "rollup-plugin-peer-deps-external": "^2.2.2",
@@ -47,8 +53,8 @@
   },
   "scripts": {
     "test": "npm run build && jest --config ./jest.config.js",
-    "lint": "eslint src",
-    "lint-fix": "eslint --fix src --ext .js",
+    "lint": "eslint src/**/*.ts",
+    "lint:fix": "eslint src/**/*.ts --fix",
     "clean": "rimraf lib es",
     "build:es": "rollup -c",
     "build:lib": "rollup -c ./rollup.config.lib.js",

package.json

@@ -23,7 +23,6 @@
     +---------------+-------+------------+------------+------------+
 */
 
-
 declare module '@arduino/cbor-js' {
   export function encode(value: SenML[], numericKeys?: boolean): ArrayBuffer;
   export function decode(data: ArrayBuffer, tagger?: (value: SenML) => SenML, simpleValue?: SenML): SenML[];
@@ -45,5 +44,5 @@ declare module '@arduino/cbor-js' {
     t?: number;
     ut?: number;
     [key: string]: any;
-  }
-}
+  };
+}

src/@arduino/cbor-js.d.ts

@@ -1,37 +1,37 @@
 import { IHttpClient } from '../http/IHttpClient';
-import { Connection } from "../connection/Connection";
-import { IConnection } from "../connection/IConnection";
+import { Connection } from '../connection/Connection';
+import { IConnection } from '../connection/IConnection';
 import { IConnectionBuilder } from './IConnectionBuilder';
-import { APIOptions, CloudOptions, BaseCloudOptions } from "../client/ICloudClient";
+import { APIOptions, CloudOptions, BaseCloudOptions } from '../client/ICloudClient';
 
 type AccessResponse = {
-  "access_token": string;
-  "expires_in": string;
-  "token_type": string;
-}
+  access_token: string;
+  expires_in: string;
+  token_type: string;
+};
 
 export class APIConnectionBuilder implements IConnectionBuilder {
-  constructor(private client: IHttpClient) { }
+  constructor(private client: IHttpClient) {}
 
   public canBuild(options: CloudOptions): boolean {
     return isApiOptions(options);
   }
 
   public async build(options: APIOptions & BaseCloudOptions): Promise<IConnection> {
-    const { apiUrl = "https://api2.arduino.cc/iot/v1/clients/token" } = options;
+    const { apiUrl = 'https://api2.arduino.cc/iot/v1/clients/token' } = options;
     const headers = { 'content-type': 'application/x-www-form-urlencoded' };
 
     const body = new URLSearchParams();
-    body.append("grant_type", 'client_credentials');
-    body.append("client_id", options.clientId);
-    body.append("client_secret", options.clientSecret);
-    body.append("audience", options.audience || 'https://api2.arduino.cc/iot');
+    body.append('grant_type', 'client_credentials');
+    body.append('client_id', options.clientId);
+    body.append('client_secret', options.clientSecret);
+    body.append('audience', options.audience || 'https://api2.arduino.cc/iot');
 
     const { access_token } = await this.client.post<AccessResponse>(apiUrl, body, headers);
-    return Connection.From(options.host, options.port, access_token)
+    return Connection.From(options.host, options.port, access_token);
   }
 }
 
 function isApiOptions(options: CloudOptions): options is APIOptions {
   return !!(options as APIOptions).clientId;
-}
+}

src/builder/APIConnectionBuilder.ts

@@ -1,7 +1,7 @@
-import { IConnection } from "../connection/IConnection";
-import { CloudOptions } from "../client/ICloudClient";
+import { IConnection } from '../connection/IConnection';
+import { CloudOptions } from '../client/ICloudClient';
 
 export interface IConnectionBuilder {
   canBuild(options: CloudOptions): boolean;
   build(options: CloudOptions): Promise<IConnection>;
-}
+}

src/builder/IConnectionBuilder.ts

@@ -1,7 +1,7 @@
-import { Connection } from "../connection/Connection";
-import { IConnection } from "../connection/IConnection";
+import { Connection } from '../connection/Connection';
+import { IConnection } from '../connection/IConnection';
 import { IConnectionBuilder } from './IConnectionBuilder';
-import { BrowserOptions, CloudOptions, BaseCloudOptions } from "../client/ICloudClient";
+import { BrowserOptions, CloudOptions, BaseCloudOptions } from '../client/ICloudClient';
 
 export class TokenConnectionBuilder implements IConnectionBuilder {
   canBuild(options: CloudOptions): boolean {

src/builder/TokenConnectionBuilder.ts

@@ -1,11 +1,11 @@
-import { filter } from "rxjs/operators";
-import { Subscription, Subject, Observable } from "rxjs";
+import { filter } from 'rxjs/operators';
+import { Subscription, Subject, Observable } from 'rxjs';
 
-import SenML from "../senML";
-import Utils from "../utils";
+import SenML from '../senML';
+import Utils from '../utils';
 import { IConnectionBuilder } from '../builder/IConnectionBuilder';
-import { IConnection, CloudMessage } from "../connection/IConnection";
-import { ICloudClient, CloudOptions, OnMessageCallback, CloudMessageValue } from "./ICloudClient";
+import { IConnection, CloudMessage } from '../connection/IConnection';
+import { ICloudClient, CloudOptions, OnMessageCallback, CloudMessageValue } from './ICloudClient';
 
 const NOOP = () => null;
 export class CloudClient implements ICloudClient {
@@ -30,15 +30,15 @@ export class CloudClient implements ICloudClient {
     return client;
   }
 
-  constructor(private builders: IConnectionBuilder[] = []) { }
+  constructor(private builders: IConnectionBuilder[] = []) {}
 
   public async connect(options: CloudOptions): Promise<IConnection> {
     this.options = { ...this.options, ...options };
-    const builder = this.builders.find(b => b.canBuild(this.options));
+    const builder = this.builders.find((b) => b.canBuild(this.options));
 
     if (!builder) throw new Error('connection failed: options not valid');
 
-    const connection = await builder.build(this.options)
+    const connection = await builder.build(this.options);
     return this.init(connection);
   }
 
@@ -69,7 +69,7 @@ export class CloudClient implements ICloudClient {
 
       this.connection = null;
       Object.values(this.subscriptions).forEach((subs, topic) => {
-        subs.forEach(sub => sub.unsubscribe())
+        subs.forEach((sub) => sub.unsubscribe());
         delete this.callbacks[topic];
         delete this.subscriptions[topic];
       });
@@ -92,14 +92,14 @@ export class CloudClient implements ICloudClient {
 
         await this.connect({ ...this.options, token: newToken });
 
-        Object.keys(this.subscriptions).forEach(topic => {
-          this.subscriptions[topic].forEach(sub => sub.unsubscribe());
+        Object.keys(this.subscriptions).forEach((topic) => {
+          this.subscriptions[topic].forEach((sub) => sub.unsubscribe());
           delete this.subscriptions[topic];
 
           const callbacks = [...this.callbacks[topic]];
           delete this.callbacks[topic];
-          callbacks.forEach(cb => this.subscribe(topic, cb));
-        })
+          callbacks.forEach((cb) => this.subscribe(topic, cb));
+        });
 
         const { onConnected = NOOP } = this.options;
         onConnected();
@@ -122,7 +122,10 @@ export class CloudClient implements ICloudClient {
       if (!this.connection) return reject(new Error('send message failed: no connection found'));
 
       const body = Utils.isString(message) ? Buffer.from(message, 'utf8') : message;
-      this.connection.publish(topic, Utils.toBuffer(body), { qos: 1, retain: false });
+      this.connection.publish(topic, Utils.toBuffer(body), {
+        qos: 1,
+        retain: false,
+      });
       return resolve();
     });
   }
@@ -139,13 +142,25 @@ export class CloudClient implements ICloudClient {
     return this.unsubscribe(`/a/d/${deviceId}/s/o`);
   }
 
-  public async sendProperty<T extends CloudMessageValue>(thingId: string, name: string, value: T, timestamp: number = new Date().getTime()): Promise<void> {
+  public async sendProperty<T extends CloudMessageValue>(
+    thingId: string,
+    name: string,
+    value: T,
+    timestamp: number = new Date().getTime()
+  ): Promise<void> {
     const topic = `/a/t/${thingId}/e/i`;
     const values = SenML.parse(name, value, timestamp, this.options.useCloudProtocolV2, null);
-    return this.sendMessage(topic, SenML.CBOR.encode(Utils.isArray(values) ? values : [values], this.options.useCloudProtocolV2));
+    return this.sendMessage(
+      topic,
+      SenML.CBOR.encode(Utils.isArray(values) ? values : [values], this.options.useCloudProtocolV2)
+    );
   }
 
-  public async onPropertyValue<T extends CloudMessageValue>(thingId: string, name: string, cb: OnMessageCallback<T>): Promise<void> {
+  public async onPropertyValue<T extends CloudMessageValue>(
+    thingId: string,
+    name: string,
+    cb: OnMessageCallback<T>
+  ): Promise<void> {
     if (!name) throw new Error('Invalid property name');
     if (typeof cb !== 'function') throw new Error('Invalid callback');
 
@@ -157,8 +172,9 @@ export class CloudClient implements ICloudClient {
     this.callbacks[topic].push(cb);
     this.subscriptions[topic].push(
       this.messagesFrom(topic)
-        .pipe(filter(v => v.propertyName === name))
-        .subscribe(v => cb(v.value as T)));
+        .pipe(filter((v) => v.propertyName === name))
+        .subscribe((v) => cb(v.value as T))
+    );
   }
 
   private subscribe<T extends CloudMessageValue>(topic: string, cb: OnMessageCallback<T>): Promise<void> {
@@ -168,9 +184,7 @@ export class CloudClient implements ICloudClient {
         this.callbacks[topic].push(cb);
 
         this.subscriptions[topic] = this.subscriptions[topic] = [];
-        this.subscriptions[topic].push(
-          this.messagesFrom(topic)
-            .subscribe(v => cb(v.value as T)));
+        this.subscriptions[topic].push(this.messagesFrom(topic).subscribe((v) => cb(v.value as T)));
 
         return resolve();
       } catch (err) {
@@ -183,7 +197,7 @@ export class CloudClient implements ICloudClient {
     return new Promise((resolve, reject) => {
       if (!this.connection) return reject(new Error('unsubscribe failed: no connection found'));
 
-      return this.connection.unsubscribe(topic, null, (err) => err ? reject() : resolve());
+      return this.connection.unsubscribe(topic, null, (err) => (err ? reject() : resolve()));
     });
   }
 
@@ -195,16 +209,14 @@ export class CloudClient implements ICloudClient {
     this.connection.subscribe(topic, (err) => {
       if (err) throw new Error(`subscription failed: ${err.toString()}`);
 
-      subscription = this.connection.messages
-        .pipe(filter(v => v.topic === topic))
-        .subscribe(v => subject.next(v));
+      subscription = this.connection.messages.pipe(filter((v) => v.topic === topic)).subscribe((v) => subject.next(v));
     });
 
     const originalMethod = subject.unsubscribe;
     subject.unsubscribe = () => {
       subscription.unsubscribe();
       originalMethod();
-    }
+    };
     return subject;
   }
 }

src/client/CloudClient.ts

@@ -1,4 +1,4 @@
-import { IConnection } from "../connection/IConnection";
+import { IConnection } from '../connection/IConnection';
 
 export type BaseCloudOptions = {
   host?: string;
@@ -8,7 +8,7 @@ export type BaseCloudOptions = {
   onConnected?: () => void;
   onDisconnect?: (message?: any) => void;
   useCloudProtocolV2?: boolean;
-}
+};
 
 export type BrowserOptions = {
   token: string;
@@ -48,4 +48,4 @@ export interface ICloudClient {
 
   sendProperty<T extends CloudMessageValue>(thingId: string, name: string, value: T, timestamp?: number): Promise<void>;
   onPropertyValue<T extends CloudMessageValue>(thingId: string, name: string, cb: OnMessageCallback<T>): Promise<void>;
-}
+}

src/client/ICloudClient.ts

@@ -1,39 +1,39 @@
 import jws from 'jws';
 import mqtt from 'mqtt';
-import { Observable, Subject } from "rxjs";
+import { Observable, Subject } from 'rxjs';
 
 import SenML from '../senML';
-import Utils from "../utils";
-import { CloudMessageValue } from "../client/ICloudClient";
-import { IConnection, CloudMessage, ConnectionOptions } from "./IConnection";
+import Utils from '../utils';
+import { CloudMessageValue } from '../client/ICloudClient';
+import { IConnection, CloudMessage, ConnectionOptions } from './IConnection';
 
 const BaseConnectionOptions: Partial<ConnectionOptions> = {
   clean: true,
   keepalive: 30,
   properties: {},
   protocolVersion: 4,
   connectTimeout: 30000,
-}
+};
 
 export class Connection implements IConnection {
   public token: string;
   public messages: Observable<CloudMessage>;
-  
+
   private _client: mqtt.MqttClient;
   private get client(): mqtt.MqttClient {
     return this._client;
   }
 
   private set client(client: mqtt.MqttClient) {
     this._client = client;
-    const messages = this.messages = new Subject<CloudMessage>();
+    const messages = (this.messages = new Subject<CloudMessage>());
 
     this._client.on('message', (topic, msg) => {
       if (topic.indexOf('/s/o') > -1) messages.next({ topic, value: msg.toString() });
       else this.messagesFrom(topic, msg).forEach((m) => messages.next(m));
     });
-  };
-  
+  }
+
   public static async From(host: string, port: string | number, token: string): Promise<IConnection> {
     if (!token) throw new Error('connection failed: you need to provide a valid token');
     if (!host) throw new Error('connection failed: you need to provide a valid host (broker)');
@@ -46,16 +46,19 @@ export class Connection implements IConnection {
     };
 
     const connection = new Connection();
-    connection.client = mqtt.connect(`wss://${host}:${port}/mqtt`, { ...BaseConnectionOptions, ...options });
+    connection.client = mqtt.connect(`wss://${host}:${port}/mqtt`, {
+      ...BaseConnectionOptions,
+      ...options,
+    });
     connection.token = token;
-    return connection
+    return connection;
   }
 
   public on(event: any, cb: any): IConnection {
     this.client.on(event, cb);
     return this;
   }
-  public end(force?: boolean, opts?: Object, cb?: mqtt.CloseCallback): IConnection {
+  public end(force?: boolean, opts?: Record<string, any>, cb?: mqtt.CloseCallback): IConnection {
     this.client.end(force, opts, cb);
     return this;
   }
@@ -94,16 +97,16 @@ export class Connection implements IConnection {
       if (previous === '') previous = current;
 
       if (previous !== current) {
-        messages.push({ topic, propertyName: previous, value: valueToSend })
+        messages.push({ topic, propertyName: previous, value: valueToSend });
         previous = current;
         valueToSend = {};
       }
 
       if (attribute) valueToSend[attribute] = value;
-      else valueToSend = value
+      else valueToSend = value;
     });
 
-    if (valueToSend !== {}) messages.push({ topic, propertyName: current, value: valueToSend })
+    if (valueToSend !== {}) messages.push({ topic, propertyName: current, value: valueToSend });
 
     return messages;
   }

src/connection/Connection.ts

@@ -1,36 +1,45 @@
-
-import { Observable } from "rxjs";
+import { Observable } from 'rxjs';
 import {
-  IClientOptions, OnConnectCallback, OnMessageCallback, OnPacketCallback,
-  OnErrorCallback, CloseCallback, IClientReconnectOptions, PacketCallback, IClientPublishOptions
+  IClientOptions,
+  OnConnectCallback,
+  OnMessageCallback,
+  OnPacketCallback,
+  OnErrorCallback,
+  CloseCallback,
+  IClientReconnectOptions,
+  PacketCallback,
+  IClientPublishOptions,
 } from 'mqtt';
 
-import { CloudMessageValue } from "../client/ICloudClient";
+import { CloudMessageValue } from '../client/ICloudClient';
 
 export type ConnectionOptions = IClientOptions;
-export type CloudMessage = { topic: string; propertyName?: string; value: CloudMessageValue };
+export type CloudMessage = {
+  topic: string;
+  propertyName?: string;
+  value: CloudMessageValue;
+};
 
 export interface IConnection {
   token?: string;
   messages?: Observable<CloudMessage>;
 
-  on(event: "connect", cb: OnConnectCallback): IConnection;
-  on(event: "message", cb: OnMessageCallback): IConnection;
-  on(event: "packetsend" | "packetreceive", cb: OnPacketCallback): IConnection;
-  on(event: "error", cb: OnErrorCallback): IConnection;
+  on(event: 'connect', cb: OnConnectCallback): IConnection;
+  on(event: 'message', cb: OnMessageCallback): IConnection;
+  on(event: 'packetsend' | 'packetreceive', cb: OnPacketCallback): IConnection;
+  on(event: 'error', cb: OnErrorCallback): IConnection;
   on(event: string, cb: Function): IConnection;
-  on(event: any, cb: any): IConnection
+  on(event: any, cb: any): IConnection;
 
-  end(force?: boolean, opts?: Object, cb?: CloseCallback): IConnection
+  end(force?: boolean, opts?: Record<string, any>, cb?: CloseCallback): IConnection;
 
-  reconnect(opts?: IClientReconnectOptions): IConnection
+  reconnect(opts?: IClientReconnectOptions): IConnection;
 
-  unsubscribe(topic: string | string[], opts?: Object, callback?: PacketCallback): IConnection
+  unsubscribe(topic: string | string[], opts?: Record<string, any>, callback?: PacketCallback): IConnection;
 
   publish(topic: string, message: string | Buffer, opts: IClientPublishOptions, callback?: PacketCallback): IConnection;
   publish(topic: string, message: string | Buffer, callback?: PacketCallback): IConnection;
   publish(topic: any, message: any, opts?: any, callback?: any): IConnection;
 
   subscribe(topic: any, callback?: any): IConnection;
 }
-

src/connection/IConnection.ts

@@ -4,12 +4,17 @@ type Fetch = (url: string, init?: any) => Promise<any>;
 
 export class HttpClientFactory {
   public static Create(fetch: Fetch): IHttpClient {
-    return new class implements IHttpClient {
-      post<T, P>(uri: string, body: P, headers?: { [key: string]: string; }): Promise<T> {
+    return new (class implements IHttpClient {
+      post<T, P>(uri: string, body: P, headers?: { [key: string]: string }): Promise<T> {
         return this.execute(uri, 'post', body, headers);
       }
 
-      private async execute<T>(url: string, method: string, body?: any, headers?: { [key: string]: string; }): Promise<T> {
+      private async execute<T>(
+        url: string,
+        method: string,
+        body?: any,
+        headers?: { [key: string]: string }
+      ): Promise<T> {
         const response = await fetch(url, { method, body, headers });
         const responseHeaders = this.mapFrom(response.headers);
 
@@ -21,11 +26,11 @@ export class HttpClientFactory {
         else return payload;
       }
 
-      private mapFrom(headers: any): { [key: string]: string; } {
+      private mapFrom(headers: any): { [key: string]: string } {
         const mapped = {};
         headers.forEach((v, n) => (mapped[n] = v));
         return mapped;
       }
-    }
+    })();
   }
 }

src/http/HttpClientFactory.ts

@@ -1,3 +1,3 @@
 export interface IHttpClient {
-  post<T, P = any>(uri: string, body: P, headers?: {[key: string]: string }): Promise<T>
-}
+  post<T, P = any>(uri: string, body: P, headers?: { [key: string]: string }): Promise<T>;
+}

src/http/IHttpClient.ts

@@ -1,49 +1,78 @@
 import CBOR, { SenML } from '@arduino/cbor-js';
 
-import Utils from "../utils";
-import { CloudMessageValue } from "../client/ICloudClient";
+import Utils from '../utils';
+import { CloudMessageValue } from '../client/ICloudClient';
 
 function isPropertyValue(message: SenML | string[]): message is SenML {
   return !!(message as SenML).n;
 }
 
 function valueFrom(message: SenML | string[]): CloudMessageValue {
-  return isPropertyValue(message)
-    ? message.v || message.vs || message.vb
-    : message[2] || message[3] || message[4];
+  return isPropertyValue(message) ? message.v || message.vs || message.vb : message[2] || message[3] || message[4];
 }
 
 function nameFrom(property: SenML | string[]): string {
-  return isPropertyValue(property) ? property.n : property[0]
+  return isPropertyValue(property) ? property.n : property[0];
 }
 
 function toString(value: SenML[], numericKeys?: boolean): string {
   const encoded = CBOR.encode(value, numericKeys);
   return Utils.arrayBufferToBase64(encoded);
-};
+}
 
 function toCloudProtocolV2(cborValue: SenML): SenML {
   const cloudV2CBORValue = {};
   let cborLabel = null;
 
   Object.keys(cborValue).forEach((label) => {
     switch (label) {
-      case 'bn': cborLabel = -2; break;
-      case 'bt': cborLabel = -3; break;
-      case 'bu': cborLabel = -4; break;
-      case 'bv': cborLabel = -5; break;
-      case 'bs': cborLabel = -6; break;
-      case 'bver': cborLabel = -1; break;
-      case 'n': cborLabel = 0; break;
-      case 'u': cborLabel = 1; break;
-      case 'v': cborLabel = 2; break;
-      case 'vs': cborLabel = 3; break;
-      case 'vb': cborLabel = 4; break;
-      case 'vd': cborLabel = 8; break;
-      case 's': cborLabel = 5; break;
-      case 't': cborLabel = 6; break;
-      case 'ut': cborLabel = 7; break;
-      default: cborLabel = label;
+      case 'bn':
+        cborLabel = -2;
+        break;
+      case 'bt':
+        cborLabel = -3;
+        break;
+      case 'bu':
+        cborLabel = -4;
+        break;
+      case 'bv':
+        cborLabel = -5;
+        break;
+      case 'bs':
+        cborLabel = -6;
+        break;
+      case 'bver':
+        cborLabel = -1;
+        break;
+      case 'n':
+        cborLabel = 0;
+        break;
+      case 'u':
+        cborLabel = 1;
+        break;
+      case 'v':
+        cborLabel = 2;
+        break;
+      case 'vs':
+        cborLabel = 3;
+        break;
+      case 'vb':
+        cborLabel = 4;
+        break;
+      case 'vd':
+        cborLabel = 8;
+        break;
+      case 's':
+        cborLabel = 5;
+        break;
+      case 't':
+        cborLabel = 6;
+        break;
+      case 'ut':
+        cborLabel = 7;
+        break;
+      default:
+        cborLabel = label;
     }
 
     cloudV2CBORValue[cborLabel] = cborValue[label];
@@ -54,7 +83,7 @@ function toCloudProtocolV2(cborValue: SenML): SenML {
 
 function format(value: CloudMessageValue, name: string, timestamp: number, deviceId: string): SenML {
   const parsed: SenML = {};
-  if (timestamp !== -1) parsed.bt = timestamp || new Date().getTime()
+  if (timestamp !== -1) parsed.bt = timestamp || new Date().getTime();
   parsed.n = name;
 
   if (deviceId) {
@@ -68,18 +97,25 @@ function format(value: CloudMessageValue, name: string, timestamp: number, devic
   return parsed;
 }
 
-function parse(name: string, value: CloudMessageValue, timestamp: number, useCloudProtocolV2: boolean, deviceId: string): SenML | SenML[] {
+function parse(
+  name: string,
+  value: CloudMessageValue,
+  timestamp: number,
+  useCloudProtocolV2: boolean,
+  deviceId: string
+): SenML | SenML[] {
   if (timestamp && !Number.isInteger(timestamp)) throw new Error('Timestamp must be Integer');
   if (name === undefined || typeof name !== 'string') throw new Error('Name must be a valid string');
 
-  if (Utils.isObject(value)) return Object.keys(value)
-    .map((key, i) => format(value[key], `${name}:${key}`, i === 0 ? timestamp : -1, i === 0 ? deviceId : undefined))
-    .map((cborValue) => useCloudProtocolV2 ? toCloudProtocolV2(cborValue) : cborValue);
+  if (Utils.isObject(value))
+    return Object.keys(value)
+      .map((key, i) => format(value[key], `${name}:${key}`, i === 0 ? timestamp : -1, i === 0 ? deviceId : undefined))
+      .map((cborValue) => (useCloudProtocolV2 ? toCloudProtocolV2(cborValue) : cborValue));
 
   let cborValue = format(value, name, timestamp, deviceId);
   if (useCloudProtocolV2) cborValue = toCloudProtocolV2(cborValue);
   return cborValue;
-};
+}
 
 export default {
   CBOR,
@@ -89,4 +125,4 @@ export default {
   nameFrom,
   isPropertyValue,
   toCloudProtocolV2,
-}
+};

src/senML/index.ts

@@ -1,4 +1,4 @@
-import { CloudMessageValue } from "../client/ICloudClient";
+import { CloudMessageValue } from '../client/ICloudClient';
 
 class ArduinoCloudError extends Error {
   constructor(public code: number, message: string) {
@@ -12,19 +12,19 @@ class ArduinoCloudError extends Error {
 }
 
 function isObject(value: CloudMessageValue): value is object {
-  return typeof (value) === "object";
+  return typeof value === 'object';
 }
 
 function isNumber(value: CloudMessageValue): value is number {
-  return typeof (value) === "number";
+  return typeof value === 'number';
 }
 
 function isString(value: CloudMessageValue): value is string {
-  return typeof (value) === "string";
+  return typeof value === 'string';
 }
 
 function isBoolean(value: CloudMessageValue): value is boolean {
-  return typeof (value) === "boolean";
+  return typeof value === 'boolean';
 }
 
 function isArray<T>(value: CloudMessageValue): value is T[] {
@@ -41,9 +41,9 @@ function toArrayBuffer(buf: { length: number }): ArrayBuffer {
 }
 
 function toBuffer(ab: ArrayBuffer): Buffer {
-  var buffer = new Buffer(ab.byteLength);
-  var view = new Uint8Array(ab);
-  for (var i = 0; i < buffer.length; ++i) {
+  const buffer = new Buffer(ab.byteLength);
+  const view = new Uint8Array(ab);
+  for (let i = 0; i < buffer.length; ++i) {
     buffer[i] = view[i];
   }
   return buffer;
@@ -57,7 +57,7 @@ function arrayBufferToBase64(buf: ArrayBuffer): string {
     binary += String.fromCharCode(bytes[i]);
   }
   return window.btoa(binary);
-};
+}
 
 export default {
   ArduinoCloudError,
@@ -68,5 +68,5 @@ export default {
   isArray,
   toArrayBuffer,
   toBuffer,
-  arrayBufferToBase64
-};
+  arrayBufferToBase64,
+};