Skip to content

Commit 3486ccd

Browse files
committed
bugfix: fix boolean minor bug
1 parent 800824c commit 3486ccd

File tree

2 files changed

+12
-8
lines changed

2 files changed

+12
-8
lines changed

src/senML/index.ts

+3-3
Original file line numberDiff line numberDiff line change
@@ -102,9 +102,9 @@ export function format(value: CloudMessageValue, name: string, timestamp: number
102102
parsed.bn = `urn:uuid:${deviceId}`;
103103
}
104104

105-
if (Utils.isNumber(value)) parsed.v = value;
106-
if (Utils.isString(value)) parsed.vs = value;
107-
if (Utils.isBoolean(value)) parsed.vb = value;
105+
if (Utils.isNumber(value)) parsed.v = Number(value);
106+
if (Utils.isString(value)) parsed.vs = String(value);
107+
if (Utils.isBoolean(value)) parsed.vb = Boolean(value);
108108

109109
return parsed;
110110
}

src/utils/index.ts

+9-5
Original file line numberDiff line numberDiff line change
@@ -11,24 +11,28 @@ export class ArduinoCloudError extends Error {
1111
}
1212
}
1313

14+
export function isNil(value: unknown): value is undefined | null {
15+
return value === undefined || value == null;
16+
}
17+
1418
export function isObject(value: CloudMessageValue): value is object {
15-
return value && typeof value === 'object';
19+
return !isNil(value) && typeof value === 'object';
1620
}
1721

1822
export function isNumber(value: CloudMessageValue): value is number {
19-
return value && typeof value === 'number';
23+
return !isNil(value) && typeof value === 'number';
2024
}
2125

2226
export function isString(value: CloudMessageValue): value is string {
23-
return value && typeof value === 'string';
27+
return !isNil(value) && typeof value === 'string';
2428
}
2529

2630
export function isBoolean(value: CloudMessageValue): value is boolean {
27-
return value && typeof value === 'boolean';
31+
return !isNil(value) && typeof value === 'boolean';
2832
}
2933

3034
export function isArray<T>(value: CloudMessageValue): value is T[] {
31-
return value && Array.isArray(value);
35+
return !isNil(value) && Array.isArray(value);
3236
}
3337

3438
export function isNotAnEmptyObject(value: any): boolean {

0 commit comments

Comments
 (0)