ucloud: minor code improvements.

Author: iabdalkader

aiotcloud/ucloud.py

@@ -65,30 +65,27 @@ def __repr__(self):
         return f"{self.value}"
 
     def __contains__(self, key):
-        if isinstance(self.value, dict):
-            return key in self._value
-        return False
-
-    @property
-    def initialized(self):
-        if isinstance(self.value, dict):
-            for r in self.value.values():
-                if not r.initialized: return False
-        return self.value is not None
+        return isinstance(self.value, dict) and key in self._value
 
     @property
     def updated(self):
         if isinstance(self.value, dict):
-            for r in self.value.values():
-                if r._updated: return True
+            return any(r._updated for r in self.value.values())
         return self._updated
 
     @updated.setter
     def updated(self, value):
         if isinstance(self.value, dict):
-            for r in self.value.values(): r._updated = value
+            for r in self.value.values():
+                r._updated = value
         self._updated = value
 
+    @property
+    def initialized(self):
+        if isinstance(self.value, dict):
+            return all(r.initialized for r in self.value.values())
+        return self.value is not None
+
     @SenmlRecord.value.setter
     def value(self, value):
         if value is not None:
@@ -127,7 +124,7 @@ def add_to_pack(self, pack):
         if isinstance(self.value, dict):
             for r in self.value.values():
                 # NOTE: should filter by updated when it's supported.
-                if r.value is not None:
+                if r.value is not None: # and r.updated
                     pack.add(r)
         else:
             pack.add(self)