Dark theme implementation #991
Merged
+736
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
per1234
requested changes
May 16, 2022
per1234
approved these changes
May 17, 2022
There was a problem hiding this comment.
I don't have a familiarity with the other components, but the GitHub Actions workflow looks perfect.
Thanks for your work on this valuable system @francescospissu!
kittaakos
approved these changes
May 24, 2022
There was a problem hiding this comment.
It looks good 👍
Can we generate the theme JSON files with an empty newline at the end? Please also insert a blank line to the .gitignore file.
GitHub will show this to you 👇
In the long run, the generator and its dependencies should not be part of the IDE. We should move them to subfolders. It makes no sense to install, build, test, and webpack the IDE to generate the style sheets.
fstasi
approved these changes
Jun 6, 2022
Co-authored-by: per1234 <[email protected]>
Co-authored-by: per1234 <[email protected]>
Co-authored-by: per1234 <[email protected]>
Co-authored-by: per1234 <[email protected]>
Co-authored-by: per1234 <[email protected]>
francescospissu
force-pushed
the
fspissu/dark-theme-implementation
branch
from
16e9850 to
1b1a9ed
Compare
|
@francescospissu, please squash the commits before merging the PR. Thank you! |
per1234
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The dark theme was missing and must be implemented.
Change description
A workflow has been implemented for creating Arduino theme files (default and dark) which pull data from Figma (via JsonBIN).
Reviewer checklist