Skip to content

[ATL-1571] Fix editor quick suggestions preference #494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 2, 2021
Merged

[ATL-1571] Fix editor quick suggestions preference #494

merged 2 commits into from
Sep 2, 2021

Conversation

AlbyIanna
Copy link
Contributor

We were getting quickSuggestion instead of quickSuggestions :')

@AlbyIanna AlbyIanna requested a review from fstasi August 31, 2021 12:50
fstasi
fstasi approved these changes Aug 31, 2021
View reviewed changes
Copy link
Contributor

@fstasi fstasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think this was a typo on my side. What I really don't like is that we were unable to find it via typescript 🤔

@AlbyIanna
Copy link
Contributor Author

AlbyIanna commented Aug 31, 2021 •
edited
Loading

@fstasi I agree, I'll put a little more effort into this and try to solve it

@AlbyIanna AlbyIanna merged commit 658c19f into main Sep 2, 2021
@AlbyIanna AlbyIanna deleted the atl-1571--fix-editor-quick-suggestions branch September 2, 2021 10:50
@per1234 per1234 mentioned this pull request Sep 3, 2021
Closed
@per1234 per1234 added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Oct 24, 2021
@per1234 per1234 mentioned this pull request Oct 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fstasi fstasi fstasi approved these changes

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlbyIanna @fstasi @per1234