Skip to content

ATL-1451: reveal sketch directory in file explorer #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 13, 2021
Merged

ATL-1451: reveal sketch directory in file explorer #450

merged 1 commit into from
Jul 13, 2021

Conversation

fstasi
Copy link
Contributor

@fstasi fstasi commented Jul 12, 2021

Why

Reveal sketchbook directory in explorer/finder is not working. This is caused by the node.id not being a valid URI.

How

Correctly parse the node.uri to a valid, independent, path, via fileService.fsPath. Then use remote.shell.openPath(fsPath); to open the sketch directory

Notes

Jira Task:

@fstasi fstasi requested a review from AlbyIanna July 12, 2021 15:22
@fstasi fstasi force-pushed the atl-1451--reveal-in-file-explorer branch from ec71004 to 64fe047 Compare July 13, 2021 09:45
AlbyIanna
AlbyIanna approved these changes Jul 13, 2021
View reviewed changes
Copy link
Contributor

@AlbyIanna AlbyIanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fstasi fstasi changed the base branch from improve-sketchbook-tree to main July 13, 2021 09:50
@fstasi fstasi closed this Jul 13, 2021
@fstasi fstasi reopened this Jul 13, 2021
@fstasi fstasi merged commit 4e6f9ae into main Jul 13, 2021
@fstasi fstasi deleted the atl-1451--reveal-in-file-explorer branch July 13, 2021 13:09
@per1234 per1234 mentioned this pull request Jul 27, 2021
Closed
@per1234 per1234 added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Oct 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlbyIanna AlbyIanna AlbyIanna approved these changes

Assignees

@umbynos umbynos

Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fstasi @AlbyIanna @per1234 @umbynos