From 852969606b1e63387c1bcf93e0ad1b217826c97c Mon Sep 17 00:00:00 2001 From: Akos Kitta Date: Thu, 11 May 2023 15:29:06 +0200 Subject: [PATCH] fix: show no errors if users cancel lib install Throwing and catching a `UserAbortError` is part of the natural flow. Closes #2063 Signed-off-by: Akos Kitta --- .../widgets/component-list/filterable-list-container.tsx | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/arduino-ide-extension/src/browser/widgets/component-list/filterable-list-container.tsx b/arduino-ide-extension/src/browser/widgets/component-list/filterable-list-container.tsx index ae90068a7..7732568c8 100644 --- a/arduino-ide-extension/src/browser/widgets/component-list/filterable-list-container.tsx +++ b/arduino-ide-extension/src/browser/widgets/component-list/filterable-list-container.tsx @@ -13,7 +13,7 @@ import { } from '../../../common/protocol/installable'; import { ArduinoComponent } from '../../../common/protocol/arduino-component'; import { SearchBar } from './search-bar'; -import { ListWidget } from './list-widget'; +import { ListWidget, UserAbortError } from './list-widget'; import { ComponentList } from './component-list'; import { ListItemRenderer } from './list-item-renderer'; import { @@ -148,6 +148,11 @@ export class FilterableListContainer< try { await install({ item, progressId, version }); } catch (err) { + if (err instanceof UserAbortError) { + // Do not toast an error message on user abort. + // https://github.com/arduino/arduino-ide/issues/2063 + return; + } const message = LibraryPackage.is(item) // TODO: this dispatch does not belong here ? libraryInstallFailed(name, version) : platformInstallFailed(name, version);