Skip to content

Corrected library.properties assignment w.r.t description and summary #2026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 21, 2023
Merged

Corrected library.properties assignment w.r.t description and summary #2026

merged 1 commit into from
Apr 21, 2023

Conversation

kittaakos
Copy link
Contributor

Motivation

To save some part of an excellent work of @nmzaheer from #1611.

Comparison with Arduino 2.0.2 on the left and Arduino 2.0.1 on the right

gffhfhfhfghf

Although the Boards/Library Manager UI has been updated in arduino/arduino-ide#1927, the description vs. summary handling is still a fix IDE2 needs.

Change description

Other information

Ref: #1611

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@kittaakos kittaakos added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Apr 20, 2023
@kittaakos kittaakos requested review from AlbyIanna and per1234 April 20, 2023 12:51
@kittaakos kittaakos self-assigned this Apr 20, 2023
@kittaakos kittaakos mentioned this pull request Apr 20, 2023
Closed
4 tasks
per1234
per1234 approved these changes Apr 21, 2023
View reviewed changes
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nmzaheer and Akos!

@kittaakos kittaakos merged commit b451e2d into main Apr 21, 2023
@kittaakos kittaakos deleted the fix-paragraph-sentence branch April 21, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@per1234 per1234 per1234 approved these changes

@AlbyIanna AlbyIanna Awaiting requested review from AlbyIanna

Assignees

@kittaakos kittaakos

Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kittaakos @per1234 @nmzaheer