Skip to content

chore: latest VSIX handles custom directories.data #1975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2023
Merged

chore: latest VSIX handles custom directories.data #1975

merged 1 commit into from
Mar 28, 2023

Conversation

kittaakos
Copy link
Contributor

@kittaakos kittaakos commented Mar 22, 2023

Motivation

When generating the debug configuration in IDE2, the CLI config path must be used for the debug -I command so that the CLI won't give a false positive error due to the missing platform.

Change description

Other information

This PR is just a preview. First, arduino/vscode-arduino-tools#40 should be merged, and IDE2 must use the latest version instead of picking up the VSIX from a GH branch. A new VSIX version has been released, and this PR uses it. ✅

Closes #1911

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@kittaakos kittaakos added type: imperfection Perceived defect in any part of project topic: debugger Related to the integrated debugger labels Mar 22, 2023
@kittaakos kittaakos requested review from AlbyIanna and per1234 March 22, 2023 12:29
@kittaakos kittaakos self-assigned this Mar 22, 2023
so when starting the debugger the CLI config path is used by the CLI for
the `daemon -I` command.

Closes #1911

Signed-off-by: Akos Kitta <[email protected]>
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Akos!

@per1234 per1234 added the topic: infrastructure Related to project infrastructure label Mar 28, 2023
@kittaakos kittaakos merged commit dafb245 into main Mar 28, 2023
@kittaakos kittaakos deleted the #1911 branch March 28, 2023 06:20
@fpistm
Copy link

fpistm commented Mar 28, 2023

Thanks @kittaakos

@kittaakos
Copy link
Contributor Author

Thank you for your contribution via the quality bug reports, @fpistm 🙏

The fix will be available from tomorrow's nightly build: https://www.arduino.cc/en/software#nightly-builds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: debugger Related to the integrated debugger topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When core is not installed in the default location, debug cannot launched properly
3 participants