From 8cd72972da91d189c4f900036ff697962f372834 Mon Sep 17 00:00:00 2001 From: Akos Kitta Date: Wed, 7 Dec 2022 16:13:41 +0100 Subject: [PATCH] feat: show the selected board config value on menu closes #343 Signed-off-by: Akos Kitta --- .../src/browser/boards/boards-data-menu-updater.ts | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/arduino-ide-extension/src/browser/boards/boards-data-menu-updater.ts b/arduino-ide-extension/src/browser/boards/boards-data-menu-updater.ts index 192c32d78..23b1e2504 100644 --- a/arduino-ide-extension/src/browser/boards/boards-data-menu-updater.ts +++ b/arduino-ide-extension/src/browser/boards/boards-data-menu-updater.ts @@ -80,16 +80,16 @@ export class BoardsDataMenuUpdater implements FrontendApplicationContribution { string, Disposable & { label: string } >(); + let selectedValue = ''; for (const value of values) { const id = `${fqbn}-${option}--${value.value}`; const command = { id }; - const selectedValue = value.value; const handler = { execute: () => this.boardsDataStore.selectConfigOption({ fqbn, option, - selectedValue, + selectedValue: value.value, }), isToggled: () => value.selected, }; @@ -100,8 +100,14 @@ export class BoardsDataMenuUpdater implements FrontendApplicationContribution { { label: value.label } ) ); + if (value.selected) { + selectedValue = value.label; + } } - this.menuRegistry.registerSubmenu(menuPath, label); + this.menuRegistry.registerSubmenu( + menuPath, + `${label}${selectedValue ? `: "${selectedValue}"` : ''}` + ); this.toDisposeOnBoardChange.pushAll([ ...commands.values(), Disposable.create(() =>