Skip to content

#1526 Ensure exact match when installing Arduino_BuiltIn on the first IDE2 startup #1531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 7, 2022
Merged

#1526 Ensure exact match when installing Arduino_BuiltIn on the first IDE2 startup #1531

merged 1 commit into from
Oct 7, 2022

Conversation

kittaakos
Copy link
Contributor

@kittaakos kittaakos commented Oct 5, 2022 •
edited
Loading

Motivation

This PR depends on #1530. ✅

This PR ensures that the Arduino_BuiltIn will be installed on the first start in case of absence.

Change description

Other information

To verify:

Closes #1526

Local verification after wiping the localStorage content and starting IDE2.

Platform arduino:[email protected] already installed
Already installed [email protected]
Already installed [email protected]
Already installed [email protected]
Already installed [email protected]
Already installed [email protected]
Already installed [email protected]
Already installed [email protected]
Already installed [email protected]
Already installed [email protected]
Already installed [email protected]

Platform arduino:[email protected] already installed
Already installed [email protected]
Already installed [email protected]
Already installed [email protected]
Already installed [email protected]
Already installed [email protected]
Already installed [email protected]
Already installed [email protected]
Already installed [email protected]
Already installed [email protected]
Already installed [email protected]

Platform arduino:[email protected] already installed
Already installed [email protected]
Already installed [email protected]
Already installed [email protected]
Already installed [email protected]
Already installed [email protected]
Already installed [email protected]
Already installed [email protected]
Already installed [email protected]
Already installed [email protected]
Already installed [email protected]

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@kittaakos kittaakos added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Oct 5, 2022
@kittaakos kittaakos requested review from AlbyIanna and per1234 October 5, 2022 14:05
AlbyIanna
AlbyIanna approved these changes Oct 7, 2022
View reviewed changes
Copy link
Contributor

@AlbyIanna AlbyIanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

Ensure exact match when installing Arduino_BuiltIn
00fc911 
on the first IDE2 startup.

Closes #1526

Signed-off-by: Akos Kitta <[email protected]>
@kittaakos kittaakos merged commit 2d2be1f into main Oct 7, 2022
@kittaakos kittaakos deleted the #1526 branch October 7, 2022 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlbyIanna AlbyIanna AlbyIanna approved these changes

@per1234 per1234 per1234 approved these changes

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect libraries installed by first run installation
3 participants
@kittaakos @AlbyIanna @per1234