Skip to content

Correct text of "INSTALLED" label in Library/Boards Manager #1507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2022
Merged

Correct text of "INSTALLED" label in Library/Boards Manager #1507

merged 1 commit into from
Oct 3, 2022

Conversation

per1234
Copy link
Contributor

@per1234 per1234 commented Sep 30, 2022

Motivation

An "INSTALLED" label is shown on the items in the Library Manager and Boards Manager views that are currently installed on the user's system:

image

During some work to add missing internationalization to the UI strings (#1449), this text was changed to "INSTALL".

image

"INSTALL" is not appropriate for what this label is intended to communicate.

Change description

Correct the regression, while retaining the internationalization of the string.

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

An "INSTALLED" label is shown on the items in the Library Manager and Boards Manager views that are currently installed
on the user's system.

During some work to add missing internationalization to the UI strings, this text was changed to "INSTALL". That text is
not appropriate for what this label is intended to communicate.

The regression is hereby corrected, while retaining the internationalization of the string.
@per1234 per1234 added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Sep 30, 2022
@per1234 per1234 self-assigned this Sep 30, 2022
@nmzaheer
Copy link
Contributor

nmzaheer commented Oct 1, 2022

Is there a reason why "INSTALL" & "INSTALLED" are in all Caps while "Uninstall" is not?

@per1234
Copy link
Contributor Author

per1234 commented Oct 1, 2022

I also wondered about this @nmzaheer.

From a previous discussion I had the impression the plan was to avoid imposing such styling within the strings themselves, instead relying on the code (e.g., CSS) to provide the styling:

#1341 (comment)

Can we use search board or Search board and transform it to upper case with CSS? See any example here.

I suggest we not force contributors helping with the translation to use the upper case. What do you think?

I like this approach because the use of correct capitalization in the strings makes it easier for the translators to understand the meaning of the source strings (which may not be as obvious outside the context of the IDE UI). All caps implies a string is an acronym, which has very different considerations for translation than a normal word.

@davegarthsimpson davegarthsimpson self-requested a review October 3, 2022 07:46
@per1234 per1234 merged commit 32b70ef into arduino:main Oct 3, 2022
@per1234 per1234 deleted the fix-installed-label branch October 3, 2022 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants