#1380 #1381 #1387 Improved the scrolling UX in list widgets #1385
Conversation
kittaakos
added
topic: code
There was a problem hiding this comment.
This fixes #1380 for me.
I find that an offset between the mouse pointer position and the scrollbar position does still accumulate as reported in #1381, but the magnitude is significantly less, so it doesn't harm the usability so much. In some cases, I find it now pushes the scrollbar ahead of the pointer instead of behind.
Thanks Akos!
kittaakos
force-pushed
the
#1380
branch
2 times, most recently
from
122ad8d to
a256d6c
Compare
kittaakos
changed the title
|
Per, could you please take another look? I think the UX is better now, and the changes should cover #1387. Thank you! Update:
Could you please verify all three issues? 😊 |
kittaakos
changed the title
There was a problem hiding this comment.
Describe the problem
When the mouse pointer is hovered over one of the Library/Boards Manager or list items, a version menu and "INSTALL" button are added at the bottom of the item, which increases its vertical size.
🐛 When the length of the listings fits within the vertical dimension of the view when not hovered, but does not fit when hovered, some glitches occur.
To reproduce
- Open the "Library Manager" view.
- Type
arduinoiotcloudin the "Filter your search..." field.
ⓘ This is only an arbitrary example of a search that produces a suitable length of listings. By chance it has the perfect length for the default window and view dimensions on my machine. - Resize the vertical dimension of the Arduino IDE window so that it is just long enough to show the full listings while in the non-hovered state, without a scrollbar on the Library Manager view.
- Hover the mouse pointer over "Arduino_ConnectionHandler".
🐛 Only half the "INSTALL" button is shown:
- Hover the mouse pointer over "ArduinoIoTCloud".
🐛 The "INSTALL" button is not shown:
- Hover the mouse pointer over "ArduinoIoTCloudBearSSL".
- Move the mouse pointer horizontally until it is over the scrollbar (as would be a common user action after they see they need to scroll down to reach the version menu and buttons).
🐛 The "Library Manager" view flickers rapidly between two states:
The flicker rate in real life is actually far higher than shown in the screencast GIF (the software was not able to capture it properly).
Arduino IDE version
2.0.0-rc9.2.snapshot-f869314 (tester build for fe69093).
Operating system
Windows 10
Additional context
The issue also occurs with the previous build from this PR (though the flicker rate is lower): 0694c24.
The issue does not occur with the latest build from the main branch: 20cc34c
- Fixed scrollbar does not reach end of list widget. - Estimated row heights to provide better scroll UX. - Last item's `<select>` must be visible. Closes #1380 Closes #1381 Closes #1387 Signed-off-by: Akos Kitta <[email protected]>
|
Thank you for the steps. I could reproduce the glitches and fix them locally. Could you please try again with the latest build? Thank you! |
There was a problem hiding this comment.
I verified this resolves #1380, #1381, and #1387.
The "flicker" bug I reported in my previous review is fixed. The issue with the buttons reported in that review is mitigated, though not 100% fixed, but it is not a serious defect and so I don't see that it is cause to delay the valuable advancements already provided by this PR. I will submit a separate report to track the remaining component (UPDATE, here: #1403).
Thanks Akos!
Motivation
Improves the scrolling in the library/boards manager widgets.
Change description
Other information
Closes #1380
Closes #1381
Closes #1387
Reviewer checklist