Skip to content

Align functional max-min of scale stepper to actual max-min zoom level #1345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 24, 2022
Merged

Align functional max-min of scale stepper to actual max-min zoom level #1345

merged 1 commit into from
Aug 24, 2022

Conversation

davegarthsimpson
Copy link
Contributor

Motivation

Small fix for correctness. we are yet to decide whether or not to impose a specific max/min level of zoom in the IDE, in the meantime, to avoid confusion we should ensure the max-min zoom of the scale stepper reflects the actual max-min zoom of the application.

Change description

Changes hard coded max-min values used by the scale stepper.

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@per1234 per1234 added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Aug 24, 2022
francescospissu
francescospissu approved these changes Aug 24, 2022
View reviewed changes
Copy link
Contributor

@francescospissu francescospissu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@davegarthsimpson davegarthsimpson merged commit b5f9aa0 into main Aug 24, 2022
@davegarthsimpson davegarthsimpson deleted the align-scale-stepper-with-actual-max-min branch August 24, 2022 10:32
@per1234 per1234 mentioned this pull request Sep 5, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francescospissu francescospissu francescospissu approved these changes

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davegarthsimpson @francescospissu @per1234