Fix board selector synchronization #1214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
per1234
added
topic: code
per1234
approved these changes
Jul 19, 2022
There was a problem hiding this comment.
I verified this fixes:
- It's possible to unselect a board #1204
- Board Selector only updates on board selection via other interfaces if associated port is selected #1206
-
update available boards in boardsServiceProvider when fqbn changes (this fixes a bug that was there in RC8 too)
Thanks Alberto!
kittaakos
approved these changes
Jul 19, 2022
91volt
approved these changes
Jul 19, 2022
This was
linked to
issues
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The Board selector is not correctly synchronized when the board/port config changes, which results in inconsistent and confusing UI.
We also want to prevent deselecting the current board from the Board Selector by clicking on Unknown boards
#1204
#1206
Change description
boardsServiceProviderwhen showing the currently selected board and port https://github.com/arduino/arduino-ide/pull/1214/files#diff-85056a8e2611f77f68cc49f8ea30ab9e5e8ea370f0123e9f1ac63b404fc36195L202-R213boardsServiceProviderwhen fqbn changes (this fixes a bug that was there in RC8 too) https://github.com/arduino/arduino-ide/pull/1214/files#diff-e42c82bb67e277cfa4598239952afd65db44dba55dc7d68df619dfccfa648279R519Other information
Reviewer checklist