#1161: Fixed missing core client in the monitor service. #1162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kittaakos
changed the title
kittaakos
added
topic: code
Restored monitor service creation state before a36524e: Pass core client provider into new instances as a field. Closes #1161 Signed-off-by: Akos Kitta <[email protected]>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To fix non-functional monitor in IDE2.
Change description
Restored monitor service creation state before a36524e:
Pass core client-provider into new instances as a field.
This PR restores the state of the following files before #1132:
arduino-ide-extension/src/node/monitor-manager.ts(changes from breaking PR here),arduino-ide-extension/src/node/monitor-service-factory.ts(here),arduino-ide-extension/src/node/monitor-service.ts(here),arduino-ide-extension/src/node/arduino-ide-backend-module.ts: (here)Other information
Closes #1161
Reviewer checklist