Skip to content

Missing board option and Programmer menus for manually installed platforms #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
per1234 opened this issue Oct 21, 2021 · 2 comments · Fixed by #826
Closed

Missing board option and Programmer menus for manually installed platforms #565

per1234 opened this issue Oct 21, 2021 · 2 comments · Fixed by #826
Assignees
Labels
conclusion: resolved Issue was resolved criticality: high Of high impact priority: high Resolution is a high priority topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project

Comments

@per1234
Copy link
Contributor

per1234 commented Oct 21, 2021

Describe the bug

Menus are not added to the Arduino IDE Tools menu for boards of platforms installed to the sketchbook folder which have custom board options.

A Programmer menu is not added to the Arduino IDE Tools menu when a board of a platform installed to the sketchbook folder is selected.

To Reproduce
Steps to reproduce the behavior:

  1. Do a manual installation of the attiny:avr boards platform to the sketchbook. For example:
    git clone https://github.com/damellis/attiny ~/Arduino/hardware/attiny/avr
    
    Note: The issue is not specific to the attiny:avr platform. It should occur with any platform that has custom board menus.
  2. Start the Arduino IDE.
  3. Select Tools > Board > ATtiny Microcontrollers (in Sketchbook) > ATtiny24/44/45 from the Arduino IDE menus.
  4. Open the Tools menu. Note that there is no Processor, Clock, or Programmer menu, even though the attiny:avr:ATtinyX4 board has custom menus. and inherits programmers from the referenced arduino:avr core.

image

They are handled correctly by the classic IDE:
image
and by Arduino CLI:

per@HAL MINGW64 /c/ide 2/arduino-ide_nightly-20211021_Windows_64bit/resources/app/node_modules/arduino-ide-extension/build
$ ./arduino-cli board details attiny:avr:ATtinyX4
Board name:            ATtiny24/44/84
FQBN:                  attiny:avr:ATtinyX4

Package name:          attiny

Platform name:         ATtiny Microcontrollers
Platform architecture: avr

Option:                Processor                       cpu
                       ATtiny24                   ✔    cpu=attiny24
                       ATtiny44                        cpu=attiny44
                       ATtiny84                        cpu=attiny84
Option:                Clock                           clock
                       Internal 1 MHz             ✔    clock=internal1
                       Internal 8 MHz                  clock=internal8
                       External 8 MHz                  clock=external8
                       External 16 MHz                 clock=external16
                       External 20 MHz                 clock=external20
Programmers:           Id                         Name

(arduino-cli doesn't show the board's referenced programmers, but the output is the same even with the working Boards Manager installation, so I'm not sure it's related)

If you install the same platform via Boards Manager, the menus are shown as expected:

image

Expected behavior
Menus should be added to the Tools menu for programmers and custom options of the selected board regardless of how the board's platform was installed.

Desktop (please complete the following information):

  • OS: Windows 10, Ubuntu 20.04
  • Version: 2.0.0-beta.12-nightly.20211021
    Date: 2021-10-21T03:03:16.691Z
    CLI Version: 0.19.1 alpha [718bbbf2]

Additional context

Originally reported at:

Related: #126

@per1234 per1234 added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Oct 21, 2021
@ubidefeo ubidefeo added the priority: high Resolution is a high priority label Oct 27, 2021
@rsora rsora added criticality: high Of high impact and removed priority: high Resolution is a high priority labels Nov 2, 2021
@ubidefeo ubidefeo added the priority: medium Resolution is a medium priority label Nov 4, 2021
@ubidefeo ubidefeo assigned rsora and unassigned rsora and umbynos Nov 15, 2021
@ubidefeo ubidefeo assigned ubidefeo and unassigned rsora Jan 24, 2022
@ubidefeo ubidefeo added priority: high Resolution is a high priority and removed priority: medium Resolution is a medium priority labels Jan 25, 2022
@ubidefeo ubidefeo added this to the arduino-ide rc4 milestone Feb 4, 2022
@ubidefeo
Copy link

ubidefeo commented Feb 4, 2022

@silvanocerza , I've assigned this one to you after some reviews and tests.
This is an important thing to work out since it impacts development of cores which is carried out using the Sketchbook's Hardware folder

@silvanocerza
Copy link
Contributor

The problem seems to be in the IDE, I just verified the CLI is correctly returning the necessary information via gRPC. I'll get to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: resolved Issue was resolved criticality: high Of high impact priority: high Resolution is a high priority topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants