Skip to content

Save sketch does not work with CMD+S on macOS (12.6.5) with Swiss German keyboard #2029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 tasks done
CptHolzschnauz opened this issue Apr 21, 2023 · 7 comments
Closed
3 tasks done
Labels
conclusion: duplicate Has already been submitted topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project

Comments

@CptHolzschnauz
Copy link

CptHolzschnauz commented Apr 21, 2023

Describe the problem

The shortcut is enabled in config, the dropdown "Save" is working but the shortcut Command+S isn't.

Swiss German Keyboard.

To reproduce

Get a swiss german keyboard.

Expected behavior

Save the file after pressing Command+S

Arduino IDE version

2.1.0

Operating system

macOS

Operating system version

12.6.5

Additional context

Keywords

  • "keyboard shortcut"

  • "key binding"

  • "keybinding"

  • "hotkey"

  • "hot key"

  • "key sequence"

  • "key chord"

  • "keyboard layout"

Issue checklist

  • I searched for previous reports in the issue tracker
  • I verified the problem still occurs when using the latest nightly build
  • My report contains all necessary details
@CptHolzschnauz CptHolzschnauz added the type: imperfection Perceived defect in any part of project label Apr 21, 2023
@kittaakos kittaakos changed the title Mac OS 12.6.5 CMD & S is not working Save sketch does not work with CMD+S on macOS (12.6.5) with Swiss German keyboard Apr 27, 2023
@kittaakos
Copy link
Contributor

kittaakos commented Apr 27, 2023

Thanks for taking the time and reporting it to us. I could not reproduce the bug with a Swiss German keyboard layout. It worked fine with 2.1.0 on macOS 12.6.3 (21G419).

2029.mp4

Could you please try to see if you can save resources with +S with the latest Theia Blueprint application? Here is the download link: https://theia-ide.org/docs/blueprint_download#downloads

@kittaakos kittaakos added status: waiting for information More information must be provided before work can proceed os: macos Specific to macOS operating system labels Apr 27, 2023
@CptHolzschnauz
Copy link
Author

Hmm, i see. Then it must be the hardware (the swiss keyboard on a 2017 iMac), i don't know.
I installed the IDE on my M2 Air with swiss keyboard and the behaviour is opposite,
the IDE does like autosave (local and remote sketch) immediately (I just changed the code without pressing a key).
See the white dot disappears automatic:

Bildschirmaufnahme.2023-04-27.um.21.02.16.mov

I don't get it tbh, is there a setting for this feature?

@kittaakos
Copy link
Contributor

Hi, auto-save is enabled by default in IDE2. Whenever you type, IDE2 will save your changes after a couple of hundred milliseconds. If you want to disable it, you can do it from the settings dialog.

2029_autosave.mp4

Now that you know how to turn auto-save on/off, please help me understand your problem with CMD+S on a Swiss German keyboard. Do you have auto-save off, and when you press CMD+S, the editor content is not saved? Thanks

@CptHolzschnauz
Copy link
Author

Hi
Didn't know that. With my M2 Air everything works a expected with the swiss german shortcut.
I'm abroad for the next days and i will test again on my Intel iMac after my return and post the results here.
Thank you for your work!
PS: The new release was a big step forward with the "git" features.

@per1234
Copy link
Contributor

per1234 commented Sep 28, 2023

Hi @CptHolzschnauz. We are still waiting for you to provide the information requested in the previous replies so that we can proceed with the investigation or evaluation of this.

Please comment here with the requested information.

@CptHolzschnauz
Copy link
Author

CptHolzschnauz commented Oct 1, 2023

Hi @per1234
Sorry, i forgot.
Behaviour is still the same, on the M2 Mac Air everything works as intended, with my iMac (Retina 5K, 27-inch, Late 2015)
it's not saving with cmd+s, so
"Do you have auto-save off, and when you press CMD+S, the editor content is not saved? Thanks"
Exactly, it's not saved on my intel based imac. Auto save works perfectly.

IDE 2.2.1, both computers have a Swiss-German keyboard.

UPDATE: I tested it with a old MAC Pro, Intel based, Swiss-German keyboard, everything works as intended.

@per1234 per1234 changed the title Save sketch does not work with CMD+S on macOS (12.6.5) with Swiss German keyboard Shortcut keys broken on non-English/US/QWERTY layouts Aug 14, 2024
@per1234 per1234 added topic: code Related to content of the project itself and removed status: waiting for information More information must be provided before work can proceed os: macos Specific to macOS operating system labels Aug 14, 2024
@per1234 per1234 changed the title Shortcut keys broken on non-English/US/QWERTY layouts Save sketch does not work with CMD+S on macOS (12.6.5) with Swiss German keyboard Aug 14, 2024
@per1234
Copy link
Contributor

per1234 commented Aug 14, 2024

I see we have another report of this problem: #2263 Even though this one was submitted first, it is a bit ambiguous so I'm going to close this in favor of the other.

If you end up with additional information to share, feel free to comment in the other thread.

Thanks for your report!

@per1234 per1234 closed this as not planned Won't fix, can't repro, duplicate, stale Aug 14, 2024
@per1234 per1234 added the conclusion: duplicate Has already been submitted label Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: duplicate Has already been submitted topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

No branches or pull requests

3 participants