Skip to content

[dev] Clean up the custom color registry items #1226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks done
kittaakos opened this issue Jul 19, 2022 · 0 comments · Fixed by #1252
Closed
3 tasks done

[dev] Clean up the custom color registry items #1226

kittaakos opened this issue Jul 19, 2022 · 0 comments · Fixed by #1252
Assignees
@91volt @francescospissu
Labels
conclusion: resolved Issue was resolved priority: high Resolution is a high priority topic: code Related to content of the project itself topic: theme Related to GUI theming

Comments

@kittaakos
Copy link
Contributor

kittaakos commented Jul 19, 2022 •
edited
Loading

Describe the problem

RC-8 could show the board selector with eight custom colors, the current state fails to do the same with 17 custom color entries.

Clean it up. Adjust other themes with the fallback.

To reproduce

This is a code quality issue.

Expected behavior

The themes work, IDE2 code does not contain unused color entries.

Arduino IDE version

7680194

Operating system

macOS

Operating system version

12.3.1

Additional context

No response

Issue checklist

  • I searched for previous reports in the issue tracker
  • I verified the problem still occurs when using the latest nightly build
  • My report contains all necessary details
@kittaakos kittaakos added topic: code Related to content of the project itself topic: theme Related to GUI theming labels Jul 19, 2022
@ubidefeo ubidefeo added criticality: high Of high impact priority: high Resolution is a high priority and removed criticality: high Of high impact labels Jul 20, 2022
@francescospissu francescospissu mentioned this issue Jul 25, 2022
Merged
4 tasks
@per1234 per1234 added the conclusion: resolved Issue was resolved label Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@91volt 91volt

@francescospissu francescospissu

Labels
conclusion: resolved Issue was resolved priority: high Resolution is a high priority topic: code Related to content of the project itself topic: theme Related to GUI theming
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Custom colors clean up arduino/arduino-ide
5 participants
@kittaakos @ubidefeo @per1234 @91volt @francescospissu