Skip to content

IDE's window height is incorrectly preserved/restored between sessions #1184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks done
kittaakos opened this issue Jul 14, 2022 · 2 comments · Fixed by #1197
Closed
3 tasks done

IDE's window height is incorrectly preserved/restored between sessions #1184

kittaakos opened this issue Jul 14, 2022 · 2 comments · Fixed by #1197
Assignees
@AlbyIanna
Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project

Comments

@kittaakos
Copy link
Contributor

kittaakos commented Jul 14, 2022 •
edited by per1234
Loading

Describe the problem

If I set the IDE's window size to the min dimensions, stop and start the IDE, then the height is not preserved.

To reproduce

  • Open IDE,
  • Set the window dimension to min,
  • Stop IDE,
  • Start IDE,
  • The window height is bigger than it was before the stop.
ide2_window_height_is_not_preserved.mp4

Expected behavior

The window size is the same on IDE start as it was on IDE stop.

Arduino IDE version

a003831

Operating system

macOS

Operating system version

12.3.1

Additional context

No response

Issue checklist

  • I searched for previous reports in the issue tracker
  • I verified the problem still occurs when using the latest nightly build
  • My report contains all necessary details
@kittaakos kittaakos added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Jul 14, 2022
@kittaakos kittaakos changed the title IDE2's min height is incorrectly preserved/restored between sessions IDE2's window height is incorrectly preserved/restored between sessions Jul 14, 2022
@per1234
Copy link
Contributor

per1234 commented Jul 14, 2022

I also noticed this. I found that the growth is approximately +15 px, +60 px. That matches to these dimensions:

image

@AlbyIanna
Copy link
Contributor

It seems that using useContentSize: true messes up with the window height when creating the window.
The reason why I used useContentSize was that I wanted to set the maxHeight of the window including the top bar, which could change from one OS to another (I assume they have different dimensions).

Removing this line solves the issue. I would go for this solution now.

@AlbyIanna AlbyIanna mentioned this issue Jul 15, 2022
Merged
4 tasks
@per1234 per1234 linked a pull request Jul 16, 2022 that will close this issue
Avoid using useContentSize when creating a new window #1197
Merged
4 tasks
@per1234 per1234 added the conclusion: resolved Issue was resolved label Jul 18, 2022
@per1234 per1234 changed the title IDE2's window height is incorrectly preserved/restored between sessions IDE's window height is incorrectly preserved/restored between sessions Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlbyIanna AlbyIanna

Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Avoid using useContentSize when creating a new window arduino/arduino-ide
3 participants
@kittaakos @AlbyIanna @per1234