fix: smoother monitor widget state reset

Signed-off-by: Akos Kitta <[email protected]>

Author: Akos Kitta

Diff for: arduino-ide-extension/src/browser/serial/monitor/monitor-view-contribution.tsx

@@ -143,8 +143,7 @@ export class MonitorViewContribution
   protected async reset(): Promise<void> {
     const widget = this.tryGetWidget();
     if (widget) {
-      widget.dispose();
-      await this.openView({ activate: true, reveal: true });
+      widget.reset();
     }
   }
 

Diff for: arduino-ide-extension/src/browser/serial/monitor/monitor-widget.tsx

@@ -5,7 +5,10 @@ import {
   postConstruct,
 } from '@theia/core/shared/inversify';
 import { Emitter } from '@theia/core/lib/common/event';
-import { Disposable } from '@theia/core/lib/common/disposable';
+import {
+  Disposable,
+  DisposableCollection,
+} from '@theia/core/lib/common/disposable';
 import {
   ReactWidget,
   Message,
@@ -57,19 +60,23 @@ export class MonitorWidget extends ReactWidget {
   @inject(FrontendApplicationStateService)
   private readonly appStateService: FrontendApplicationStateService;
 
+  private readonly toDisposeOnReset: DisposableCollection;
+
   constructor() {
     super();
     this.id = MonitorWidget.ID;
     this.title.label = MonitorWidget.LABEL;
     this.title.iconClass = 'monitor-tab-icon';
     this.title.closable = true;
     this.scrollOptions = undefined;
-    this.toDispose.push(this.clearOutputEmitter);
+    this.toDisposeOnReset = new DisposableCollection();
+    this.toDispose.pushAll([this.clearOutputEmitter, this.toDisposeOnReset]);
   }
 
   @postConstruct()
   protected init(): void {
-    this.toDispose.pushAll([
+    this.toDisposeOnReset.dispose();
+    this.toDisposeOnReset.pushAll([
       Disposable.create(() => this.monitorManagerProxy.disconnect()),
       this.monitorModel.onChange(() => this.update()),
       this.monitorManagerProxy.onMonitorSettingsDidChange((event) =>
@@ -79,6 +86,10 @@ export class MonitorWidget extends ReactWidget {
     this.startMonitor();
   }
 
+  reset(): void {
+    this.init();
+  }
+
   private updateSettings(settings: MonitorSettings): void {
     this.settings = {
       ...this.settings,