add missing vars

Author: davegarthsimpson

.github/workflows/build.yml

@@ -274,6 +274,12 @@ jobs:
       BUILD_ARTIFACTS_PATH: electron-app/dist/build-artifacts
       # to skip passing signing credentials to electron-builder
       IS_WINDOWS_CONFIG: ${{ matrix.config.name == 'Windows' }}
+      INSTALLER_CERT_WINDOWS_CER: "/tmp/cert.cer"
+      # We are hardcoding the path for signtool because is not present on the windows PATH env var by default.
+      # Keep in mind that this path could change when upgrading to a new runner version
+      SIGNTOOL_PATH: "C:/Program Files (x86)/Windows Kits/10/bin/10.0.19041.0/x86/signtool.exe"
+      WIN_CERT_PASSWORD: ${{ secrets.INSTALLER_CERT_WINDOWS_PASSWORD }}
+      WIN_CERT_CONTAINER_NAME: ${{ secrets.INSTALLER_CERT_WINDOWS_CONTAINER }}
     strategy:
       matrix:
         config: ${{ fromJson(needs.select-targets.outputs.build-matrix) }}

electron-app/scripts/windowsCustomSign.js

@@ -3,8 +3,8 @@ const childProcess = require('child_process');
 exports.default = async function (configuration) {
   const SIGNTOOL_PATH = process.env.SIGNTOOL_PATH;
   const INSTALLER_CERT_WINDOWS_CER = process.env.INSTALLER_CERT_WINDOWS_CER;
-  const CERT_PASSWORD = process.env.CERT_PASSWORD;
-  const CONTAINER_NAME = process.env.CONTAINER_NAME;
+  const CERT_PASSWORD = process.env.WIN_CERT_PASSWORD;
+  const CONTAINER_NAME = process.env.WIN_CERT_CONTAINER_NAME;
   const filePath = configuration.path;
 
   if (
@@ -19,7 +19,7 @@ exports.default = async function (configuration) {
     );
   } else {
     console.warn(
-      'Custom windows signing was no performed: SIGNTOOL_PATH, INSTALLER_CERT_WINDOWS_CER, CERT_PASSWORD, and CONTAINER_NAME environment variables were not provided.'
+      `Custom windows signing was no performed one of the following variables was not provided: SIGNTOOL_PATH (${SIGNTOOL_PATH}), INSTALLER_CERT_WINDOWS_CERT (${INSTALLER_CERT_WINDOWS_CER}), CERT_PASSWORD (${CERT_PASSWORD}), CONTAINER_NAME (${CONTAINER_NAME})`
     );
     process.exit(1);
   }