recalculate artifacts hash

Author: Alberto Iannaccone

Diff for: electron/build/scripts/hash.js

@@ -1,10 +1,5 @@
-const fs = require('fs');
 const isCI = require('is-ci');
 const { notarize } = require('electron-notarize');
-const utils = require('../../packager/utils');
-const { getChannelFile } = utils;
-const join = require('path').join;
-const { hashFile } = require('./hash');
 
 exports.default = async function notarizing(context) {
   if (!isCI) {
@@ -34,34 +29,4 @@ exports.default = async function notarizing(context) {
     teamId: process.env.AC_TEAM_ID,
     tool: 'notarytool',
   });
-  return await recalculateHash();
 };
-
-async function recalculateHash() {
-  const { platform } = process;
-  const cwd = join(__dirname, '..', 'build', 'dist');
-  const channelFilePath = join(cwd, getChannelFile(platform));
-  const yaml = require('yaml');
-
-  try {
-    let fileContents = fs.readFileSync(channelFilePath, 'utf8');
-    const newChannelFile = yaml.parse(fileContents);
-    const { files, path } = newChannelFile;
-    const newSha512 = await hashFile(join(cwd, path));
-    newChannelFile.sha512 = newSha512;
-    if (!!files) {
-      const newFiles = [];
-      for (let file of files) {
-        const { url } = file;
-        const { size } = fs.statSync(join(cwd, url));
-        const newSha512 = await hashFile(join(cwd, url));
-        newFiles.push({ ...file, sha512: newSha512, size });
-      }
-      newChannelFile.files = newFiles;
-    }
-    console.log(channelFilePath);
-    fs.writeFileSync(channelFilePath, yaml.stringify(newChannelFile));
-  } catch (e) {
-    console.log(e);
-  }
-}

Diff for: electron/build/scripts/notarize.js

@@ -17,9 +17,7 @@
     "electron-notarize": "^1.1.1",
     "is-ci": "^2.0.0",
     "ncp": "^2.0.0",
-    "shelljs": "^0.8.3",
-    "crypto": "^1.0.1",
-    "yaml": "^1.10.2"
+    "shelljs": "^0.8.3"
   },
   "scripts": {
     "build": "yarn download:plugins && theia build --mode development && yarn patch",
@@ -94,7 +92,9 @@
       "gatekeeperAssess": false,
       "entitlements": "resources/entitlements.mac.plist",
       "entitlementsInherit": "resources/entitlements.mac.plist",
-      "target": "default"
+      "target": [
+        "dmg"
+      ]
     },
     "linux": {
       "target": [

Diff for: electron/build/template-package.json

@@ -257,10 +257,12 @@ ${fs.readFileSync(path('..', 'build', 'package.json')).toString()}
   );
 
   //-----------------------------------------------------------------------------------------------------+
-  // Copy to another folder. Azure does not support wildcard for `[email protected]` |
+  // Recalculate artifacts hash and copy to another folder (because they can change after signing them).
+  // Azure does not support wildcard for `[email protected]` |
   //-----------------------------------------------------------------------------------------------------+
   if (isCI) {
     try {
+      await recalculateArtifactsHash();
       await copyFilesToBuildArtifacts();
     } catch (e) {
       echo(JSON.stringify(e));
@@ -400,6 +402,66 @@ ${fs.readFileSync(path('..', 'build', 'package.json')).toString()}
     }
   }
 
+  async function recalculateArtifactsHash() {
+    echo(`🚢  Detected CI, recalculating artifacts hash...`);
+    const { platform } = process;
+    const cwd = path('..', 'build', 'dist');
+    const channelFilePath = join(cwd, getChannelFile(platform));
+    const yaml = require('yaml');
+
+    try {
+      let fileContents = fs.readFileSync(channelFilePath, 'utf8');
+      const newChannelFile = yaml.parse(fileContents);
+      const { files, path } = newChannelFile;
+      const newSha512 = await hashFile(join(cwd, path));
+      newChannelFile.sha512 = newSha512;
+      if (!!files) {
+        const newFiles = [];
+        for (let file of files) {
+          const { url } = file;
+          const { size } = fs.statSync(join(cwd, url));
+          const newSha512 = await hashFile(join(cwd, url));
+          newFiles.push({ ...file, sha512: newSha512, size });
+        }
+        newChannelFile.files = newFiles;
+      }
+      console.log('=======================');
+      console.log('Printing channel file');
+      console.log(yaml.stringify(newChannelFile));
+      fs.writeFileSync(channelFilePath, yaml.stringify(newChannelFile));
+    } catch (e) {
+      console.log(e);
+    }
+  }
+
+  async function hashFile(
+    file,
+    algorithm = 'sha512',
+    encoding = 'base64',
+    options
+  ) {
+    const crypto = require('crypto');
+    return await new Promise((resolve, reject) => {
+      const hash = crypto.createHash(algorithm);
+      hash.on('error', reject).setEncoding(encoding);
+      fs.createReadStream(
+        file,
+        Object.assign({}, options, {
+          highWaterMark: 1024 * 1024,
+          /* better to use more memory but hash faster */
+        })
+      )
+        .on('error', reject)
+        .on('end', () => {
+          hash.end();
+          resolve(hash.read());
+        })
+        .pipe(hash, {
+          end: false,
+        });
+    });
+  }
+
   /**
    * Joins tha path from `__dirname`.
    */

Diff for: electron/packager/index.js

@@ -17,6 +17,7 @@
     "@types/file-type": "^10.9.1",
     "@types/temp": "^0.8.32",
     "chai": "^4.2.0",
+    "crypto": "^1.0.1",
     "dateformat": "^3.0.3",
     "deepmerge": "2.01",
     "depcheck": "^0.9.2",
@@ -28,6 +29,7 @@
     "shelljs": "^0.8.3",
     "sinon": "^9.0.1",
     "temp": "^0.9.1",
+    "yaml": "^1.10.2",
     "yargs": "^12.0.5"
   },
   "engines": {

Diff for: electron/packager/package.json

@@ -197,15 +197,9 @@ function git(command) {
 // to work correctly.
 // For more information: https://www.electron.build/auto-update
 function getChannelFile(platform) {
-  let currentChannel = '';
-  if (isNightly) {
-    currentChannel = 'beta';
-  } else if (isRelease) {
+  let currentChannel = 'beta';
+  if (isRelease) {
     currentChannel = 'latest';
-  } else {
-    // We're not creating a nightly build nor releasing
-    // a new version, no need for a channel file.
-    return '';
   }
   return (
     currentChannel +

Diff for: electron/packager/utils.js

@@ -437,6 +437,11 @@ cross-spawn@^6.0.0:
     shebang-command "^1.2.0"
     which "^1.2.9"
 
+crypto@^1.0.1:
+  version "1.0.1"
+  resolved "https://registry.yarnpkg.com/crypto/-/crypto-1.0.1.tgz#2af1b7cad8175d24c8a1b0778255794a21803037"
+  integrity sha512-VxBKmeNcqQdiUQUW2Tzq0t377b54N2bMtXO/qiLa+6eRRmmC4qT3D4OnTGoT/U6O9aklQ/jTwbOtRMTTY8G0Ig==
+
 dateformat@^3.0.3:
   version "3.0.3"
   resolved "https://registry.yarnpkg.com/dateformat/-/dateformat-3.0.3.tgz#a6e37499a4d9a9cf85ef5872044d62901c9889ae"
@@ -1597,6 +1602,11 @@ wrappy@1:
   resolved "https://registry.yarnpkg.com/y18n/-/y18n-4.0.0.tgz#95ef94f85ecc81d007c264e190a120f0a3c8566b"
   integrity sha512-r9S/ZyXu/Xu9q1tYlpsLIsa3EeLXXk0VwlxqTcFRfg9EhMW+17kbt9G0NrgCmhGb5vT2hyhJZLfDGx+7+5Uj/w==
 
+yaml@^1.10.2:
+  version "1.10.2"
+  resolved "https://registry.yarnpkg.com/yaml/-/yaml-1.10.2.tgz#2301c5ffbf12b467de8da2333a459e29e7920e4b"
+  integrity sha512-r3vXyErRCYJ7wg28yvBY5VSoAF8ZvlcW9/BwUzEtUsjvX/DKs24dIkuwjtuprwJJHsbyUbLApepYTR1BN4uHrg==
+
 [email protected], yargs-parser@^13.1.2:
   version "13.1.2"
   resolved "https://registry.yarnpkg.com/yargs-parser/-/yargs-parser-13.1.2.tgz#130f09702ebaeef2650d54ce6e3e5706f7a4fb38"