fix: a save as triggered from the sketch rename must delete the source sketch

partial revert of bec6e92

Signed-off-by: Akos Kitta <[email protected]>

Author: Akos Kitta

Diff for: arduino-ide-extension/src/browser/contributions/save-as-sketch.ts

@@ -74,17 +74,7 @@ export class SaveAsSketch extends CloudSketchContribution {
     if (cloudUri) {
       destinationUri = await this.createCloudCopy({ cloudUri, sketch });
     } else {
-      const isTemp = await this.sketchesService.isTemp(sketch);
-      if (!isTemp) {
-        // If the current sketch is an ordinary non-temp sketch, do not delete it after the rename.
-        // https://github.com/arduino/arduino-ide/issues/1882#issuecomment-1427524645
-        wipeOriginal = false;
-      }
-      destinationUri = await this.createLocalCopy(
-        sketch,
-        isTemp,
-        execOnlyIfTemp
-      );
+      destinationUri = await this.createLocalCopy(sketch, execOnlyIfTemp);
     }
     if (!destinationUri) {
       return false;
@@ -129,9 +119,9 @@ export class SaveAsSketch extends CloudSketchContribution {
 
   private async createLocalCopy(
     sketch: Sketch,
-    isTemp?: boolean,
     execOnlyIfTemp?: boolean
   ): Promise<string | undefined> {
+    const isTemp = await this.sketchesService.isTemp(sketch);
     if (!isTemp && !!execOnlyIfTemp) {
       return undefined;
     }