remove language server log preference

Author: Alberto Iannaccone

Diff for: arduino-ide-extension/src/browser/arduino-frontend-contribution.tsx

@@ -261,14 +261,6 @@ export class ArduinoFrontendContribution
       }
     };
     this.boardsServiceClientImpl.onBoardsConfigChanged(start);
-    this.arduinoPreferences.onPreferenceChanged((event) => {
-      if (
-        event.preferenceName === 'arduino.language.log' &&
-        event.newValue !== event.oldValue
-      ) {
-        start(this.boardsServiceClientImpl.boardsConfig);
-      }
-    });
     this.arduinoPreferences.ready.then(() => {
       const webContents = remote.getCurrentWebContents();
       const zoomLevel = this.arduinoPreferences.get('arduino.window.zoomLevel');
@@ -330,16 +322,6 @@ export class ArduinoFrontendContribution
         return;
       }
       this.logger.info(`Starting language server: ${fqbn}`);
-      const log = this.arduinoPreferences.get('arduino.language.log');
-      let currentSketchPath: string | undefined = undefined;
-      if (log) {
-        const currentSketch = await this.sketchServiceClient.currentSketch();
-        if (currentSketch) {
-          currentSketchPath = await this.fileService.fsPath(
-            new URI(currentSketch.uri)
-          );
-        }
-      }
       const { clangdUri, cliUri, lsUri } = await this.executableService.list();
       const [clangdPath, cliPath, lsPath, cliConfigPath] = await Promise.all([
         this.fileService.fsPath(new URI(clangdUri)),
@@ -362,7 +344,6 @@ export class ArduinoFrontendContribution
             lsPath,
             cliPath,
             clangdPath,
-            log: currentSketchPath ? currentSketchPath : log,
             cliConfigPath,
             board: {
               fqbn,

Diff for: arduino-ide-extension/src/browser/arduino-preferences.ts

@@ -12,14 +12,6 @@ import { CompilerWarningLiterals, CompilerWarnings } from '../common/protocol';
 export const ArduinoConfigSchema: PreferenceSchema = {
   type: 'object',
   properties: {
-    'arduino.language.log': {
-      type: 'boolean',
-      description: nls.localize(
-        'arduino/preferences/language.log',
-        "True if the Arduino Language Server should generate log files into the sketch folder. Otherwise, false. It's false by default."
-      ),
-      default: false,
-    },
     'arduino.compile.verbose': {
       type: 'boolean',
       description: nls.localize(
@@ -164,7 +156,6 @@ export const ArduinoConfigSchema: PreferenceSchema = {
 };
 
 export interface ArduinoConfiguration {
-  'arduino.language.log': boolean;
   'arduino.compile.verbose': boolean;
   'arduino.compile.warnings': CompilerWarnings;
   'arduino.upload.verbose': boolean;

Diff for: arduino-ide-extension/src/browser/settings.tsx

@@ -44,7 +44,6 @@ const WINDOW_SETTING = `${ARDUINO_SETTING}.window`;
 // const IDE_SETTING = `${ARDUINO_SETTING}.ide`;
 const COMPILE_SETTING = `${ARDUINO_SETTING}.compile`;
 const UPLOAD_SETTING = `${ARDUINO_SETTING}.upload`;
-const LANGUAGE_SETTING = `${ARDUINO_SETTING}.language`;
 const SKETCHBOOK_SETTING = `${ARDUINO_SETTING}.sketchbook`;
 const AUTO_SCALE_SETTING = `${WINDOW_SETTING}.autoScale`;
 const ZOOM_LEVEL_SETTING = `${WINDOW_SETTING}.zoomLevel`;
@@ -53,7 +52,6 @@ const COMPILE_VERBOSE_SETTING = `${COMPILE_SETTING}.verbose`;
 const COMPILE_WARNINGS_SETTING = `${COMPILE_SETTING}.warnings`;
 const UPLOAD_VERBOSE_SETTING = `${UPLOAD_SETTING}.verbose`;
 const UPLOAD_VERIFY_SETTING = `${UPLOAD_SETTING}.verify`;
-const LANGUAGE_LOG_SETTING = `${LANGUAGE_SETTING}.log`;
 const SHOW_ALL_FILES_SETTING = `${SKETCHBOOK_SETTING}.showAllFiles`;
 
 export interface Settings extends Index {
@@ -69,7 +67,6 @@ export interface Settings extends Index {
   compilerWarnings: CompilerWarnings; // `arduino.compile.warnings`
   verboseOnUpload: boolean; // `arduino.upload.verbose`
   verifyAfterUpload: boolean; // `arduino.upload.verify`
-  enableLsLogs: boolean; // `arduino.language.log`
   sketchbookShowAllFiles: boolean; // `arduino.sketchbook.showAllFiles`
 
   sketchbookPath: string; // CLI
@@ -127,7 +124,6 @@ export class SettingsService {
       compilerWarnings,
       verboseOnUpload,
       verifyAfterUpload,
-      enableLsLogs,
       sketchbookShowAllFiles,
       cliConfig,
     ] = await Promise.all([
@@ -151,7 +147,6 @@ export class SettingsService {
       this.preferenceService.get<any>(COMPILE_WARNINGS_SETTING, 'None'),
       this.preferenceService.get<boolean>(UPLOAD_VERBOSE_SETTING, true),
       this.preferenceService.get<boolean>(UPLOAD_VERIFY_SETTING, true),
-      this.preferenceService.get<boolean>(LANGUAGE_LOG_SETTING, true),
       this.preferenceService.get<boolean>(SHOW_ALL_FILES_SETTING, false),
       this.configService.getConfiguration(),
     ]);
@@ -169,7 +164,6 @@ export class SettingsService {
       compilerWarnings,
       verboseOnUpload,
       verifyAfterUpload,
-      enableLsLogs,
       sketchbookShowAllFiles,
       additionalUrls,
       sketchbookPath,
@@ -249,7 +243,6 @@ export class SettingsService {
       compilerWarnings,
       verboseOnUpload,
       verifyAfterUpload,
-      enableLsLogs,
       sketchbookPath,
       additionalUrls,
       network,
@@ -315,11 +308,6 @@ export class SettingsService {
         verifyAfterUpload,
         PreferenceScope.User
       ),
-      this.preferenceService.set(
-        LANGUAGE_LOG_SETTING,
-        enableLsLogs,
-        PreferenceScope.User
-      ),
       this.preferenceService.set(
         SHOW_ALL_FILES_SETTING,
         sketchbookShowAllFiles,
@@ -581,17 +569,6 @@ export class SettingsComponent extends React.Component<
             'Editor Quick Suggestions'
           )}
         </label>
-        <label className="flex-line">
-          <input
-            type="checkbox"
-            checked={this.state.enableLsLogs}
-            onChange={this.enableLsLogsDidChange}
-          />
-          {nls.localize(
-            'arduino/preferences/languageServerLogging',
-            'Enable language server logging'
-          )}
-        </label>
         <div className="flex-line">
           {nls.localize(
             'arduino/preferences/additionalManagerURLs',
@@ -814,12 +791,6 @@ export class SettingsComponent extends React.Component<
     this.setState({ autoScaleInterface: event.target.checked });
   };
 
-  protected enableLsLogsDidChange = (
-    event: React.ChangeEvent<HTMLInputElement>
-  ) => {
-    this.setState({ enableLsLogs: event.target.checked });
-  };
-
   protected interfaceScaleDidChange = (
     event: React.ChangeEvent<HTMLInputElement>
   ) => {

Diff for: i18n/en.json

@@ -25,7 +25,6 @@
             "debuggingNotSupported": "Debugging is not supported by '{0}'"
         },
         "preferences": {
-            "language.log": "True if the Arduino Language Server should generate log files into the sketch folder. Otherwise, false. It's false by default.",
             "compile.verbose": "True for verbose compile output. False by default",
             "compile.warnings": "Tells gcc which warning level to use. It's 'None' by default",
             "upload.verbose": "True for verbose upload output. False by default.",
@@ -60,14 +59,15 @@
             "verifyAfterUpload": "Verify code after upload",
             "checkForUpdates": "Check for updates on startup",
             "editorQuickSuggestions": "Editor Quick Suggestions",
-            "languageServerLogging": "Enable language server logging",
             "additionalManagerURLs": "Additional Boards Manager URLs",
             "noProxy": "No proxy",
             "manualProxy": "Manual proxy configuration",
             "newSketchbookLocation": "Select new sketchbook location",
             "choose": "Choose",
             "enterAdditionalURLs": "Enter additional URLs, one for each row",
-            "unofficialBoardSupport": "Click for a list of unofficial board support URLs"
+            "unofficialBoardSupport": "Click for a list of unofficial board support URLs",
+            "languageServerLogging": "Enable language server logging",
+            "language.log": "True if the Arduino Language Server should generate log files into the sketch folder. Otherwise, false. It's false by default."
         },
         "cloud": {
             "signIn": "SIGN IN",
@@ -322,5 +322,18 @@
     },
     "cloud": {
         "GoToCloud": "GO TO CLOUD"
-    }
+    },
+    "internalConsoleOptions": "Controls when the internal debug console should open.",
+    "debugType": "Type of configuration.",
+    "debugTypeNotRecognised": "The debug type is not recognized. Make sure that you have a corresponding debug extension installed and that it is enabled.",
+    "node2NotSupported": "\"node2\" is no longer supported, use \"node\" instead and set the \"protocol\" attribute to \"inspector\".",
+    "debugName": "Name of configuration; appears in the launch configuration drop down menu.",
+    "debugRequest": "Request type of configuration. Can be \"launch\" or \"attach\".",
+    "debugServer": "For debug extension development only: if a port is specified VS Code tries to connect to a debug adapter running in server mode",
+    "debugPrelaunchTask": "Task to run before debug session starts.",
+    "debugPostDebugTask": "Task to run after debug session ends.",
+    "debugWindowsConfiguration": "Windows specific launch configuration attributes.",
+    "debugOSXConfiguration": "OS X specific launch configuration attributes.",
+    "debugLinuxConfiguration": "Linux specific launch configuration attributes.",
+    "deprecatedVariables": "'env.', 'config.' and 'command.' are deprecated, use 'env:', 'config:' and 'command:' instead."
 }