Skip to content

Commit ae76432

Browse files
committed
Update library dependency installation dialog response indexes
Arduino libraries may specify dependencies on other libraries in their metadata. The installation of these dependencies is offered by the Arduino IDE when the user installs the dependent library using the Library Manager widget. The order of the buttons in the dialog that offers the dependencies installation was recently rearranged. The dialog response interpretation code was not updated to reflect the changes to the button indexes at that time. This caused the "CANCEL" button to trigger the behavior expected from the "INSTALL ALL" button, and vice versa. The library dependencies installation dialog response interpretation code is hereby updated to use the new button indexes.
1 parent 40807db commit ae76432

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

Diff for: arduino-ide-extension/src/browser/library/library-list-widget.ts

+4-4
Original file line numberDiff line numberDiff line change
@@ -139,12 +139,12 @@ export class LibraryListWidget extends ListWidget<
139139

140140
if (result) {
141141
const { response } = result;
142-
if (response === 0) {
143-
// All
144-
installDependencies = true;
145-
} else if (response === 1) {
142+
if (response === 1) {
146143
// Current only
147144
installDependencies = false;
145+
} else if (response === 2) {
146+
// All
147+
installDependencies = true;
148148
}
149149
}
150150
} else {

0 commit comments

Comments
 (0)