output panel buffer corrections

Author: davegarthsimpson

Diff for: arduino-ide-extension/src/node/core-service-impl.ts

@@ -78,7 +78,7 @@ export class CoreServiceImpl extends CoreClientAware implements CoreService {
     const result = client.compile(compileReq);
 
     const compileBuffer = new OutputPanelBufferProvider(
-      this.flushOutputPanelMessages,
+      this.flushOutputPanelMessages.bind(this),
       this.FLUSH_OUTPUT_MESSAGES_TIMEOUT_MS
     );
     try {
@@ -185,7 +185,7 @@ export class CoreServiceImpl extends CoreClientAware implements CoreService {
     const result = responseHandler(client, req);
 
     const uploadBuffer = new OutputPanelBufferProvider(
-      this.flushOutputPanelMessages,
+      this.flushOutputPanelMessages.bind(this),
       this.FLUSH_OUTPUT_MESSAGES_TIMEOUT_MS
     );
     try {
@@ -256,7 +256,7 @@ export class CoreServiceImpl extends CoreClientAware implements CoreService {
     const result = client.burnBootloader(burnReq);
 
     const bootloaderBuffer = new OutputPanelBufferProvider(
-      this.flushOutputPanelMessages,
+      this.flushOutputPanelMessages.bind(this),
       this.FLUSH_OUTPUT_MESSAGES_TIMEOUT_MS
     );
     try {
@@ -309,8 +309,5 @@ export class CoreServiceImpl extends CoreClientAware implements CoreService {
     this.responseService.appendToOutput({
       chunk,
     });
-    this.responseService.appendToOutput({
-      chunk,
-    });
   }
 }

Diff for: arduino-ide-extension/src/node/output-panel-buffer-provider.ts

@@ -5,9 +5,12 @@ export class OutputPanelBufferProvider {
 
   constructor(onFlush: (chunk: string) => void, flushTimeout: number) {
     this.flushInterval = setInterval(() => {
-      const chunkString = Buffer.concat(this.chunks).toString();
-      onFlush(chunkString);
-      this.clearChunks();
+      if (this.chunks.length > 0) {
+        const chunkString = Buffer.concat(this.chunks).toString();
+        this.clearChunks();
+
+        onFlush(chunkString);
+      }
     }, flushTimeout);
   }