fix: proper workaround for copy/cut/paste

Signed-off-by: Akos Kitta <[email protected]>

Author: Akos Kitta

Diff for: arduino-ide-extension/src/browser/arduino-ide-frontend-module.ts

@@ -353,6 +353,16 @@ import { FileResourceResolver } from './theia/filesystem/file-resource';
 import { FileResourceResolver as TheiaFileResourceResolver } from '@theia/filesystem/lib/browser/file-resource';
 import { StylingParticipant } from '@theia/core/lib/browser/styling-service';
 
+// Hack to fix copy/cut/paste issue after electron version update in Theia.
+// https://github.com/eclipse-theia/theia/issues/12487
+import('@theia/core/lib/browser/common-frontend-contribution.js').then(
+  (theiaCommonContribution) => {
+    theiaCommonContribution['supportCopy'] = true;
+    theiaCommonContribution['supportCut'] = true;
+    theiaCommonContribution['supportPaste'] = true;
+  }
+);
+
 export default new ContainerModule((bind, unbind, isBound, rebind) => {
   // Commands, colors, theme adjustments, and toolbar items
   bind(ArduinoFrontendContribution).toSelf().inSingletonScope();

Diff for: arduino-ide-extension/src/electron-browser/theia/core/electron-main-menu-factory.ts

@@ -14,7 +14,10 @@ import {
   ElectronMenuOptions,
   ElectronMainMenuFactory as TheiaElectronMainMenuFactory,
 } from '@theia/core/lib/electron-browser/menu/electron-main-menu-factory';
-import type { MenuDto } from '@theia/core/lib/electron-common/electron-api';
+import type {
+  MenuDto,
+  MenuRole,
+} from '@theia/core/lib/electron-common/electron-api';
 import { inject, injectable } from '@theia/core/shared/inversify';
 import {
   ArduinoMenus,
@@ -133,6 +136,15 @@ export class ElectronMainMenuFactory extends TheiaElectronMainMenuFactory {
     return { label, submenu };
   }
 
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars, unused-imports/no-unused-vars
+  protected override roleFor(id: string): MenuRole | undefined {
+    // MenuItem `roles` are completely broken on macOS:
+    //  - https://github.com/eclipse-theia/theia/issues/11217,
+    //  - https://github.com/arduino/arduino-ide/issues/969
+    // IDE2 uses commands instead.
+    return undefined;
+  }
+
   protected override fillMenuTemplate(
     parentItems: MenuDto[],
     menuModel: MenuNode,
@@ -262,12 +274,12 @@ export class ElectronMainMenuFactory extends TheiaElectronMainMenuFactory {
         execute: () => this.execute(commandId, args, options.rootMenuPath),
       };
 
-      // Do not restrict menu item roles for macOS
-      // https://github.com/eclipse-theia/theia/issues/12487
-      const role = this.roleFor(node.id);
-      if (role) {
-        menuItem.role = role;
-        delete menuItem.execute;
+      if (isOSX) {
+        const role = this.roleFor(node.id);
+        if (role) {
+          menuItem.role = role;
+          delete menuItem.execute;
+        }
       }
       parentItems.push(menuItem);