Skip to content

Commit 96e4893

Browse files
use bail var in custom sign script
1 parent 3ccc864 commit 96e4893

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

.github/workflows/build.yml

+1
Original file line numberDiff line numberDiff line change
@@ -286,6 +286,7 @@ jobs:
286286
SIGNTOOL_PATH: "C:/Program Files (x86)/Windows Kits/10/bin/10.0.19041.0/x86/signtool.exe"
287287
WIN_CERT_PASSWORD: ${{ secrets.INSTALLER_CERT_WINDOWS_PASSWORD }}
288288
WIN_CERT_CONTAINER_NAME: ${{ secrets.INSTALLER_CERT_WINDOWS_CONTAINER }}
289+
INTERNAL_ENABLE_WINDOWS_SIGNING: ${{ secrets.INTERNAL_ENABLE_WINDOWS_SIGNING }}
289290
strategy:
290291
matrix:
291292
config: ${{ fromJson(needs.select-targets.outputs.build-matrix) }}

electron-app/scripts/windowsCustomSign.js

+3-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
11
const childProcess = require('child_process');
22

33
exports.default = async function (configuration) {
4-
if (!process.env.GITHUB_ACTIONS) {
4+
const enabled = !!process.env.INTERNAL_ENABLE_WINDOWS_SIGNING;
5+
6+
if (!enabled || !process.env.GITHUB_ACTIONS) {
57
return;
68
}
79

0 commit comments

Comments
 (0)