Do not bail when wiping the temp sketch has failed

Akos Kitta · kittaakos · commit 911875665dcc · 2021-02-03T17:44:36.000+01:00
Signed-off-by: Akos Kitta &lt;kittaakos@typefox.io&gt;
diff --git a/arduino-ide-extension/src/browser/contributions/save-as-sketch.ts b/arduino-ide-extension/src/browser/contributions/save-as-sketch.ts
@@ -61,7 +61,9 @@ export class SaveAsSketch extends SketchContribution {
         const workspaceUri = await this.sketchService.copy(sketch, { destinationUri });
         if (workspaceUri && openAfterMove) {
             if (wipeOriginal || (openAfterMove && execOnlyIfTemp)) {
-                await this.fileService.delete(new URI(sketch.uri), { recursive: true });
+                try {
+                    await this.fileService.delete(new URI(sketch.uri), { recursive: true });
+                } catch { /* NOOP: from time to time, it's not possible to wipe the old resource from the temp dir on Windows */ }
             }
             this.workspaceService.open(new URI(workspaceUri), { preserveWindow: true });
         }

Original file line number	Diff line number	Diff line change
`@@ -61,7 +61,9 @@ export class SaveAsSketch extends SketchContribution {`
`61`	`61`	`const workspaceUri = await this.sketchService.copy(sketch, { destinationUri });`
`62`	`62`	`if (workspaceUri && openAfterMove) {`
`63`	`63`	`if (wipeOriginal \|\| (openAfterMove && execOnlyIfTemp)) {`
`64`		`- await this.fileService.delete(new URI(sketch.uri), { recursive: true });`
	`64`	`+ try {`
	`65`	`+ await this.fileService.delete(new URI(sketch.uri), { recursive: true });`
	`66`	`+ } catch { /* NOOP: from time to time, it's not possible to wipe the old resource from the temp dir on Windows */ }`
`65`	`67`	`}`
`66`	`68`	`this.workspaceService.open(new URI(workspaceUri), { preserveWindow: true });`
`67`	`69`	`}`