naming and param fixup

Author: davegarthsimpson

arduino-ide-extension/src/browser/boards/boards-service-provider.ts

@@ -202,7 +202,7 @@ export class BoardsServiceProvider
       const lastBoardsConfigOnUpload = this.lastBoardsConfigOnUpload;
 
       if (boardOnAppearedPort && lastBoardsConfigOnUpload.selectedBoard) {
-        const boardIsSameHardware = Board.sameDistinctHardwareAs(
+        const boardIsSameHardware = Board.hardwareIdEquals(
           boardOnAppearedPort,
           lastBoardsConfigOnUpload.selectedBoard
         );
@@ -338,7 +338,7 @@ export class BoardsServiceProvider
           ? selectedBoard
           : this._availableBoards.find(
               (availableBoard) =>
-                Board.sameDistinctHardwareAs(availableBoard, selectedBoard) ||
+                Board.hardwareIdEquals(availableBoard, selectedBoard) ||
                 Board.sameAs(availableBoard, selectedBoard)
             );
         if (
@@ -370,7 +370,7 @@ export class BoardsServiceProvider
         ({ state }) => state !== AvailableBoard.State.incomplete
       )) {
         if (
-          (Board.sameDistinctHardwareAs(
+          (Board.hardwareIdEquals(
             this.latestValidBoardsConfig.selectedBoard,
             board
           ) ||

arduino-ide-extension/src/common/protocol/boards-service.ts

@@ -554,10 +554,7 @@ export namespace Board {
     return left.name === right.name && left.fqbn === right.fqbn;
   }
 
-  export function sameDistinctHardwareAs(
-    left: Board,
-    right: string | Board
-  ): boolean {
+  export function hardwareIdEquals(left: Board, right: Board): boolean {
     if (Board.is(right) && left.port && right.port) {
       const { hardwareId: leftHardwareId } = left.port;
       const { hardwareId: rightHardwareId } = right.port;