fix: remove double fds watcher

mark all nested files as a root change

Signed-off-by: Akos Kitta <[email protected]>

Author: Akos Kitta

Diff for: arduino-ide-extension/src/browser/widgets/cloud-sketchbook/cloud-sketchbook-tree-model.ts

@@ -11,11 +11,7 @@ import { AuthenticationClientService } from '../../auth/authentication-client-se
 import { SketchbookTreeModel } from '../sketchbook/sketchbook-tree-model';
 import { WorkspaceNode } from '@theia/navigator/lib/browser/navigator-tree';
 import { CreateUri } from '../../create/create-uri';
-import {
-  FileChangesEvent,
-  FileChangeType,
-  FileStat,
-} from '@theia/filesystem/lib/common/files';
+import { FileChangesEvent, FileStat } from '@theia/filesystem/lib/common/files';
 import {
   LocalCacheFsProvider,
   LocalCacheUri,
@@ -24,7 +20,6 @@ import URI from '@theia/core/lib/common/uri';
 import { SketchCache } from './cloud-sketch-cache';
 import { Create } from '../../create/typings';
 import { nls } from '@theia/core/lib/common/nls';
-import { DisposableCollection } from '@theia/core/lib/common/disposable';
 import { Deferred } from '@theia/core/lib/common/promise-util';
 
 export function sketchBaseDir(sketch: Create.Sketch): FileStat {
@@ -72,24 +67,14 @@ export class CloudSketchbookTreeModel extends SketchbookTreeModel {
   @inject(SketchCache)
   private readonly sketchCache: SketchCache;
 
-  private readonly toDisposeOnSessionDidChange = new DisposableCollection();
   private _localCacheFsProviderReady: Deferred<void> | undefined;
 
   @postConstruct()
   protected override init(): void {
     super.init();
     this.toDispose.push(
-      this.authenticationService.onSessionDidChange((session) => {
-        this.updateRoot();
-        this.toDisposeOnSessionDidChange.dispose();
-        if (session) {
-          this.toDisposeOnSessionDidChange.push(
-            this.fileService.watch(CreateUri.root)
-          );
-        }
-      })
+      this.authenticationService.onSessionDidChange(() => this.updateRoot())
     );
-    this.ensureLocalFsProviderReady();
   }
 
   override *getNodesByUri(uri: URI): IterableIterator<TreeNode> {
@@ -119,11 +104,11 @@ export class CloudSketchbookTreeModel extends SketchbookTreeModel {
   }
 
   protected override isRootAffected(changes: FileChangesEvent): boolean {
-    return changes.changes.some(
-      (change) =>
-        change.type === FileChangeType.ADDED &&
-        change.resource.parent.toString() === LocalCacheUri.root.toString()
-    );
+    return changes.changes
+      .map(({ resource }) => resource)
+      .some(
+        (uri) => uri.parent.toString().startsWith(LocalCacheUri.root.toString()) // all files under the root might effect the tree
+      );
   }
 
   override async refresh(