Skip to content

Commit 87701d8

Browse files
Apply suggestions from code review
Co-authored-by: per1234 <[email protected]>
1 parent 00adb3e commit 87701d8

File tree

3 files changed

+4
-38
lines changed

3 files changed

+4
-38
lines changed

Diff for: .github/workflows/check-i18n-task.yml

+1-29
Original file line numberDiff line numberDiff line change
@@ -6,59 +6,31 @@ env:
66

77
# See: https://docs.github.com/en/actions/reference/events-that-trigger-workflows
88
on:
9-
create:
109
push:
1110
paths:
1211
- '.github/workflows/check-i18n-task.ya?ml'
13-
- 'package.json'
1412
- '**/package.json'
1513
- '**.ts'
1614
- 'i18n/**'
1715
pull_request:
1816
paths:
1917
- '.github/workflows/check-i18n-task.ya?ml'
20-
- 'package.json'
2118
- '**/package.json'
2219
- '**.ts'
2320
- 'i18n/**'
2421
workflow_dispatch:
2522
repository_dispatch:
2623

2724
jobs:
28-
run-determination:
29-
runs-on: ubuntu-latest
30-
outputs:
31-
result: ${{ steps.determination.outputs.result }}
32-
steps:
33-
- name: Determine if the rest of the workflow should run
34-
id: determination
35-
run: |
36-
RELEASE_BRANCH_REGEX="refs/heads/[0-9]+.[0-9]+.x"
37-
# The `create` event trigger doesn't support `branches` filters, so it's necessary to use Bash instead.
38-
if [[ \
39-
"${{ github.event_name }}" != "create" || \
40-
"${{ github.ref }}" =~ $RELEASE_BRANCH_REGEX \
41-
]]; then
42-
# Run the other jobs.
43-
RESULT="true"
44-
else
45-
# There is no need to run the other jobs.
46-
RESULT="false"
47-
fi
48-
49-
echo "::set-output name=result::$RESULT"
50-
5125
check:
52-
needs: run-determination
53-
if: needs.run-determination.outputs.result == 'true'
5426
runs-on: ubuntu-latest
5527

5628
steps:
5729
- name: Checkout repository
5830
uses: actions/checkout@v2
5931

6032
- name: Install Node.js 12.x
61-
uses: actions/setup-node@v1
33+
uses: actions/setup-node@v2
6234
with:
6335
node-version: '12.14.1'
6436
registry-url: 'https://registry.npmjs.org'

Diff for: .github/workflows/i18n-nightly-push.yml

+1-4
Original file line numberDiff line numberDiff line change
@@ -7,16 +7,13 @@ on:
77

88
jobs:
99
push-to-transifex:
10-
# This workflow is only of value to the arduino/arduino-ide repository and
11-
# would always fail in forks
12-
if: github.repository == 'arduino/arduino-ide'
1310
runs-on: ubuntu-latest
1411
steps:
1512
- name: Checkout
1613
uses: actions/checkout@v2
1714

1815
- name: Install Node.js 12.x
19-
uses: actions/setup-node@v1
16+
uses: actions/setup-node@v2
2017
with:
2118
node-version: '12.14.1'
2219
registry-url: 'https://registry.npmjs.org'

Diff for: .github/workflows/i18n-weekly-pull.yml

+2-5
Original file line numberDiff line numberDiff line change
@@ -7,16 +7,13 @@ on:
77

88
jobs:
99
pull-from-transifex:
10-
# This workflow is only of value to the arduino/arduino-ide repository and
11-
# would always fail in forks
12-
if: github.repository == 'arduino/arduino-ide'
1310
runs-on: ubuntu-latest
1411
steps:
1512
- name: Checkout
1613
uses: actions/checkout@v2
1714

1815
- name: Install Node.js 12.x
19-
uses: actions/setup-node@v1
16+
uses: actions/setup-node@v2
2017
with:
2118
node-version: '12.14.1'
2219
registry-url: 'https://registry.npmjs.org'
@@ -33,6 +30,6 @@ jobs:
3330
uses: peter-evans/create-pull-request@v3
3431
with:
3532
commit-message: Updated translation files
36-
title: Updated translation files
33+
title: Update translation files
3734
branch: i18n/translations-update
3835
author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

0 commit comments

Comments
 (0)