fix: show board info based on the selected port

include serial number of board if available

Closes #1489
Closes #1435

Signed-off-by: Akos Kitta <[email protected]>

Author: Akos Kitta

Diff for: arduino-ide-extension/src/browser/contributions/board-selection.ts

@@ -9,7 +9,10 @@ import { BoardsConfig } from '../boards/boards-config';
 import { MainMenuManager } from '../../common/main-menu-manager';
 import { BoardsListWidget } from '../boards/boards-list-widget';
 import { NotificationCenter } from '../notification-center';
-import { BoardsServiceProvider } from '../boards/boards-service-provider';
+import {
+  AvailableBoard,
+  BoardsServiceProvider,
+} from '../boards/boards-service-provider';
 import {
   ArduinoMenus,
   PlaceholderMenuNode,
@@ -79,22 +82,80 @@ export class BoardSelection extends SketchContribution {
           );
           return;
         }
-        const boardDetails = await this.boardsService.getBoardDetails({
-          fqbn: selectedBoard.fqbn,
-        });
-        if (boardDetails) {
-          const { VID, PID } = boardDetails;
-          const detail = `BN: ${selectedBoard.name}
-VID: ${VID}
-PID: ${PID}`;
-          await remote.dialog.showMessageBox(remote.getCurrentWindow(), {
-            message: nls.localize('arduino/board/boardInfo', 'Board Info'),
-            title: nls.localize('arduino/board/boardInfo', 'Board Info'),
-            type: 'info',
-            detail,
-            buttons: [nls.localize('vscode/issueMainService/ok', 'OK')],
-          });
+        // IDE2 must show the board info based on the selected port.
+        // https://github.com/arduino/arduino-ide/issues/1489
+
+        // IDE 1.x does not support network ports
+        if (selectedPort.protocol === 'network') {
+          this.messageService.info(
+            nls.localize(
+              'arduino/board/noNetworkPort',
+              "Network port, can't obtain info."
+            )
+          );
+          return;
+        }
+        const selectedPortKey = Port.keyOf(selectedPort);
+        console.log('selectedportkey', JSON.stringify(selectedPortKey));
+        console.log(
+          'availableboards',
+          JSON.stringify(
+            this.boardsServiceProvider.availableBoards.filter(
+              AvailableBoard.hasPort
+            )
+          )
+        );
+
+        const state = await this.boardsService.getState();
+        const boardListOnSelectedPort = Object.entries(state).filter(
+          ([portKey, [, boards]]) =>
+            portKey === selectedPortKey && boards.length
+        );
+        // IDE 1.x show this when cannot identify for example a ESP8266MOD although compile and upload works
+        if (!boardListOnSelectedPort.length) {
+          this.messageService.info(
+            nls.localize(
+              'arduino/board/noNativeSerialPort',
+              "Native serial port, can't obtain info."
+            )
+          );
+          return;
         }
+
+        const [, [port, boards]] = boardListOnSelectedPort[0];
+        boardListOnSelectedPort.length && boardListOnSelectedPort[0];
+        if (boardListOnSelectedPort.length > 1 || boards.length > 1) {
+          console.warn(
+            `Detected more than one available boards on the selected port : ${JSON.stringify(
+              selectedPort
+            )}. Detected boards were: ${JSON.stringify(
+              boardListOnSelectedPort
+            )}. Using the first one: ${JSON.stringify([port, boards])}`
+          );
+        }
+
+        const board = boards[0];
+        const falsyToNullString = (s: string | undefined) =>
+          !!s ? s : '(null)';
+        const readProperty = (property: string, port: Port) =>
+          falsyToNullString(port.properties?.[property]);
+        const BN = board.name;
+        const VID = readProperty('vid', port);
+        const PID = readProperty('pid', port);
+        const SN = readProperty('serialNumber', port);
+        const detail = `
+BN: ${BN}
+VID: ${VID}
+PID: ${PID}
+SN: ${SN}
+`.trim();
+        await remote.dialog.showMessageBox(remote.getCurrentWindow(), {
+          message: nls.localize('arduino/board/boardInfo', 'Board Info'),
+          title: nls.localize('arduino/board/boardInfo', 'Board Info'),
+          type: 'info',
+          detail,
+          buttons: [nls.localize('vscode/issueMainService/ok', 'OK')],
+        });
       },
     });
   }

Diff for: i18n/en.json

@@ -18,6 +18,8 @@
       "installNow": "The \"{0} {1}\" core has to be installed for the currently selected \"{2}\" board. Do you want to install it now?",
       "noBoardsFound": "No boards found for \"{0}\"",
       "noFQBN": "The FQBN is not available for the selected board \"{0}\". Do you have the corresponding core installed?",
+      "noNativeSerialPort": "Native serial port, can't obtain info.",
+      "noNetworkPort": "Network port, can't obtain info.",
       "noPortsDiscovered": "No ports discovered",
       "noPortsSelected": "No ports selected for board: '{0}'.",
       "noneSelected": "No boards selected.",